Skip to content

Ignore raft unit tests for cugraph [skip ci] - #292

Merged
ajschmidt8 merged 1 commit into
rapidsai:branch-21.06from
ajschmidt8:update-cugraph-tests
Jun 7, 2021
Merged

Ignore raft unit tests for cugraph [skip ci]#292
ajschmidt8 merged 1 commit into
rapidsai:branch-21.06from
ajschmidt8:update-cugraph-tests

Conversation

@ajschmidt8

Copy link
Copy Markdown
Member

This PR adds a flag to ignore the raft unit tests in the cugraph repo since those tests are meant to be run from the raft repo itself (and not a downstream repo).

This PR adds a flag to ignore the `raft` unit tests in the `cugraph` repo since those tests are meant to be run from the `raft` repo itself (and not a downstream repo).
@ajschmidt8
ajschmidt8 requested a review from a team as a code owner June 7, 2021 19:18

@rlratzel rlratzel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be nice if we could have a universal test script for cugraph (which was the intent behind this), much like we do with build.sh but that might be out-of-scope for this PR - just something to keep in mind to reduce maintenance later.

@dillon-cullinan

Copy link
Copy Markdown
Contributor

LGTM. It would be nice if we could have a universal test script for cugraph (which was the intent behind this), much like we do with build.sh but that might be out-of-scope for this PR - just something to keep in mind to reduce maintenance later.

We have the source builds of every repo in the images we are testing with this, so its very doable. Though I would like it to be fleshed out with all the repos.

That way we can either have a generalized script in here that references the repos via a variable and we just have a common structure and execution, which also results in us being able to combine all the nightly devel jobs into a single job.

@ajschmidt8
ajschmidt8 merged commit 58360b3 into rapidsai:branch-21.06 Jun 7, 2021
@ajschmidt8
ajschmidt8 deleted the update-cugraph-tests branch June 7, 2021 20:30
@ajschmidt8 ajschmidt8 mentioned this pull request Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants