Skip to content

[REVIEW] FIX Install rapids pytest benchmark - #289

Merged
ajschmidt8 merged 3 commits into
rapidsai:branch-21.06from
dillon-cullinan:fix-cugraphpytest
Jun 9, 2021
Merged

[REVIEW] FIX Install rapids pytest benchmark#289
ajschmidt8 merged 3 commits into
rapidsai:branch-21.06from
dillon-cullinan:fix-cugraphpytest

Conversation

@dillon-cullinan

Copy link
Copy Markdown
Contributor

cuGraph pytests are dependent on this package to run properly, otherwise they run into the following error:

10:51:23 ERROR: usage: py.test [options] [file_or_dir] [file_or_dir] [...]
10:51:23 py.test: error: unrecognized arguments: --benchmark-gpu-disable

We do not use these arguments in the script, but they are added programmatically via cugraph's pytest.ini script in their repo, seen here: https://github.com/rapidsai/cugraph/blob/branch-21.06/python/pytest.ini

@dillon-cullinan
dillon-cullinan requested a review from a team as a code owner June 1, 2021 17:16
@ajschmidt8

Copy link
Copy Markdown
Member

cuGraph pytests are dependent on this package to run properly, otherwise they run into the following error:

10:51:23 ERROR: usage: py.test [options] [file_or_dir] [file_or_dir] [...]
10:51:23 py.test: error: unrecognized arguments: --benchmark-gpu-disable

We do not use these arguments in the script, but they are added programmatically via cugraph's pytest.ini script in their repo, seen here: https://github.com/rapidsai/cugraph/blob/branch-21.06/python/pytest.ini

Good catch. One of the things we'll need to double-check here is that installing rapids-pytest-benchmark doesn't also install a different rmm version than the one that's initially provided by the environment. I believe Rick and I ran into this issue previously.

@ajschmidt8

Copy link
Copy Markdown
Member

admin merging since CI doesn't run tests related to these changes anyway.

@ajschmidt8
ajschmidt8 merged commit a2c0a22 into rapidsai:branch-21.06 Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants