Skip to content

Set relative tolerance on test - #217

Merged
raydouglass merged 1 commit into
rapidsai:branch-0.18from
ChuckHastings:bug_pagerank_needs_relative_tolerance
Feb 12, 2021
Merged

Set relative tolerance on test#217
raydouglass merged 1 commit into
rapidsai:branch-0.18from
ChuckHastings:bug_pagerank_needs_relative_tolerance

Conversation

@ChuckHastings

Copy link
Copy Markdown
Contributor

This isn't really a test to determine if pagerank is generating precise answers. Rather it is a test to determine if the basic mechanics of importing cugraph and executing an algorithm works. 3 significant digits of accuracy seems sufficient for this style of test.

@ChuckHastings
ChuckHastings requested a review from a team as a code owner February 11, 2021 22:33
@raydouglass

Copy link
Copy Markdown
Contributor

Failures are 504 conda errors and missing v0.19 images, so I'm going to admin merge it.

@raydouglass
raydouglass merged commit 46e2587 into rapidsai:branch-0.18 Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants