Update nodejs version spec - #213
Merged
Merged
Conversation
raydouglass
approved these changes
Feb 11, 2021
Merged
Contributor
|
rerun tests |
jjacobelli
approved these changes
Feb 16, 2021
rapids-bot Bot
pushed a commit
to rapidsai/cuxfilter
that referenced
this pull request
Feb 16, 2021
This PR is related to rapidsai/integration#213. Lately we've been seeing a lot of `conda` solve issues with NodeJS version 15 (see screenshots below). The solve problems add an extra ~20 minutes to CI jobs. This PR pins the Node version so that it only uses 12-14 (for reference, [14 is the current LTS](https://nodejs.org/en/)). Hopefully this helps with the `conda` conflicts.   Authors: - AJ Schmidt (@ajschmidt8) Approvers: - Ajay Thorve (@AjayThorve) - Ray Douglass (@raydouglass) - Jordan Jacobelli (@ethyling) URL: #239
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lately there have been a lot of conda errors regarding inconsistencies due to our NodeJS version (see screenshot/log below). It causes a lot of wasted time on CI jobs. This PR updates our version spec to not use Node v15. For reference, the latest LTS is 14 (src). Hopefully this helps the conda solve time/inconsistency.
Log: https://gpuci.gpuopenanalytics.com/job/rapidsai/job/gpuci/job/cugraph/job/prb/job/cugraph-gpu-test/CUDA=10.2,GPU_LABEL=gpu,OS=centos7,PYTHON=3.8/235/console
Screenshot:
