Add moto min_version at 1.3.14, update s3fs to 0.5.2 - #207
Merged
Conversation
kkraus14
approved these changes
Jan 16, 2021
ajschmidt8
approved these changes
Jan 19, 2021
rapids-bot Bot
pushed a commit
to NVIDIA/cudf
that referenced
this pull request
Jan 20, 2021
This PR updates s3 tests to use `moto_server` instead of going via a moto mock_s3 context. This enables cleaner s3 testing with `s3fs>=0.5` which incorporates aiobotocore for s3 connections. - The pytests starts up a moto-server for each worker running tests. - Ports used: `5000, 5550 - 5550+ (n_pytest_workers-1)` Updated integration repo with requirements: rapidsai/integration#207 Authors: - Ayush Dattagupta <ayushdg95@gmail.com> Approvers: - GALI PREM SAGAR (@galipremsagar) - Keith Kraus (@kkraus14) URL: #7144
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pr adds the following:
1.3.140.5.2Required for (and tested on) NVIDIA/cudf#7144