Notebook updates - #153
Merged
Merged
Conversation
|
|
||
| # PyTorch is intentionally excluded from our Docker images due | ||
| # to its size, but some notebooks still depend on it. | ||
| conda install -y -c pytorch pytorch |
Contributor
There was a problem hiding this comment.
I've been purposely holding off on pytorch for a couple reasons.
- Pytorch doesn't support CUDA 11 quite yet I don't think
- You have to remove packages from our environment to make this work, I'm not sure what other adverse effects this may have
See: https://github.com/rapidsai/cusignal/blob/branch-0.16/ci/gpu/build.sh#L88
dillon-cullinan
approved these changes
Oct 15, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes the following changes:
filterpytorapids-notebook-envfor this cusignal notebookpytorchto our notebooks CI test scripts.pytorchis intentionally excluded from our images due to its size, however some notebooks still depend on it (i.e. cusignal's E2E_Example.ipynb). Adding it here will prevent such notebooks from failing CI tests.