Skip to content

[REVIEW]Add nltk to rapids-build-env - #130

Merged
ajschmidt8 merged 1 commit into
rapidsai:branch-0.16from
VibhuJawa:fea_add_nltk_rapids_build_env
Sep 15, 2020
Merged

[REVIEW]Add nltk to rapids-build-env#130
ajschmidt8 merged 1 commit into
rapidsai:branch-0.16from
VibhuJawa:fea_add_nltk_rapids_build_env

Conversation

@VibhuJawa

Copy link
Copy Markdown
Member

Add nltk to rapids-build-env/meta.yaml .

We need nltk for adding a test for the porter stemmer implementation in PR NVIDIA/cuml#2476 .

@VibhuJawa
VibhuJawa requested a review from a team as a code owner September 15, 2020 00:08
@VibhuJawa VibhuJawa changed the title [REVIEW]Add nltk to rapids-build-env/meta.yaml [REVIEW]Add nltk to rapids-build-env Sep 15, 2020
@VibhuJawa

Copy link
Copy Markdown
Member Author

Unsure why it failed for 0.15 but i don't think it should be related to the PR.

image

@VibhuJawa VibhuJawa mentioned this pull request Sep 15, 2020
5 tasks
@ajschmidt8

ajschmidt8 commented Sep 15, 2020

Copy link
Copy Markdown
Member

Unsure why it failed for 0.15 but i don't think it should be related to the PR.

That can be ignored (fixed in #131).

Merging since all other tests passed.

@ajschmidt8
ajschmidt8 merged commit 01838fb into rapidsai:branch-0.16 Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants