This repository was archived by the owner on Jul 25, 2023. It is now read-only.
FIX Patch PR #137 by copying .condarc instead of symlink - #138
Merged
Conversation
Do not use /conda as that is a symlink
Despite testing in #137 that passed, when trying to build containers after the PR merge no `rapidsai` containers would build due to symlink errors. This approach copies the file instead which will result in a more consistent state if the `.condarc` file is modified for the `rapids` env, it will leave the `base` env intact.
ajschmidt8
approved these changes
Oct 8, 2020
Contributor
Author
|
rerun tests |
The gpuci-tools install has no retry and even in testing this PR there are conda JSON/HTTP failures. Adding the `||` with a retry on failure will try a second time to prevent the need to rebuild the container on a temporary error. In addition this removes all `source activate` mentions which are the old format and recent changes to `miniconda-cuda` has setup the environment to run without needing to invoke `source activate` on each `RUN` command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Despite testing in #137 that passed, when trying to build containers after the PR merge no
rapidsaicontainers would build due to symlink errors. This approach copies the file instead which will result in a more consistent state if the.condarcfile is modified for therapidsenv, it will leave thebaseenv intact.