remove rapids-get-pr-{conda,wheel}-artifact - #209
Conversation
|
This is working! See "How I tested this" in the description, specifically NVIDIA/cudf#19593 (comment) |
|
From the search results in your PR body, I did see this result, which may need to be updated: https://github.com/rapidsai/graph_dl/blob/25df0db6c390f35308c7d3e0276eaf48396cd878/scripts/get_ci_artifacts.sh#L118 |
|
Thanks for double-checking! Yep I already have a PR up for that: https://github.com/rapidsai/graph_dl/pull/822 And it's fine to merge this without waiting on that to be merged... I don't think there's anything automated using that repo, so they can pin back to an older |
|
Merging this now that the corresponding docs change is merged: rapidsai/docs#653 |
Contributes to #145
rapids-get-pr-conda-artifactandrapids-get-pr-wheel-artifact_rapids-get-pr-artifacttorapids-get-pr-artifactNotes for Reviewers
Is this safe to merge?
Yes, these things are only used for testing purposes in PRs, as described in https://docs.rapids.ai/resources/github-actions/#using-conda-ci-artifacts-in-other-prs
Merging this shouldn't break CI for any projects. GitHub search with evidence of that: https://github.com/search?q=org%3Arapidsai+%22rapids-get-pr%22+AND+NOT+is%3Aarchived&type=code
How I tested this
Opened an
rmmPR (rapidsai/rmm#2008) and tested that the docs as of rapidsai/docs#653 worked on acudfPR (NVIDIA/cudf#19593 (comment)).