Skip to content

remove rapids-get-pr-{conda,wheel}-artifact - #209

Merged
jameslamb merged 4 commits into
mainfrom
get-pr-artifact
Aug 8, 2025
Merged

remove rapids-get-pr-{conda,wheel}-artifact#209
jameslamb merged 4 commits into
mainfrom
get-pr-artifact

Conversation

@jameslamb

@jameslamb jameslamb commented Aug 5, 2025

Copy link
Copy Markdown
Member

Contributes to #145

  • removes rapids-get-pr-conda-artifact and rapids-get-pr-wheel-artifact
  • renames _rapids-get-pr-artifact to rapids-get-pr-artifact

Notes for Reviewers

Is this safe to merge?

Yes, these things are only used for testing purposes in PRs, as described in https://docs.rapids.ai/resources/github-actions/#using-conda-ci-artifacts-in-other-prs

Merging this shouldn't break CI for any projects. GitHub search with evidence of that: https://github.com/search?q=org%3Arapidsai+%22rapids-get-pr%22+AND+NOT+is%3Aarchived&type=code

How I tested this

Opened an rmm PR (rapidsai/rmm#2008) and tested that the docs as of rapidsai/docs#653 worked on a cudf PR (NVIDIA/cudf#19593 (comment)).

@jameslamb jameslamb added breaking Introduces a breaking change improvement Improves an existing functionality labels Aug 5, 2025
@jameslamb jameslamb changed the title WIP: remove rapids-get-pr-{conda,wheel}-artifact remove rapids-get-pr-{conda,wheel}-artifact Aug 5, 2025
@jameslamb

Copy link
Copy Markdown
Member Author

This is working! See "How I tested this" in the description, specifically NVIDIA/cudf#19593 (comment)

@jameslamb
jameslamb marked this pull request as ready for review August 5, 2025 20:55
@jameslamb
jameslamb requested a review from a team as a code owner August 5, 2025 20:55
@jameslamb
jameslamb requested review from AyodeAwe and removed request for a team August 5, 2025 20:55
@jameslamb jameslamb mentioned this pull request Aug 5, 2025
15 tasks
Comment thread tools/rapids-get-pr-artifact Outdated
@ajschmidt8

Copy link
Copy Markdown
Member

From the search results in your PR body, I did see this result, which may need to be updated: https://github.com/rapidsai/graph_dl/blob/25df0db6c390f35308c7d3e0276eaf48396cd878/scripts/get_ci_artifacts.sh#L118

@jameslamb

Copy link
Copy Markdown
Member Author

Thanks for double-checking!

Yep I already have a PR up for that: https://github.com/rapidsai/graph_dl/pull/822

And it's fine to merge this without waiting on that to be merged... I don't think there's anything automated using that repo, so they can pin back to an older gha-tools commit if needed. @nv-rliu can come yell at me if I break it 😛

@jameslamb

Copy link
Copy Markdown
Member Author

Merging this now that the corresponding docs change is merged: rapidsai/docs#653

@jameslamb
jameslamb merged commit d76b6c2 into main Aug 8, 2025
2 checks passed
@jameslamb
jameslamb deleted the get-pr-artifact branch August 8, 2025 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Introduces a breaking change improvement Improves an existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants