WIP: update Github Authentication flow - #168
Closed
jayavenkatesh19 wants to merge 4 commits into
Closed
Conversation
Contributor
|
Looks like there are conflicts here. |
Contributor
|
Asides the linked ops issue, is there focused conversation anywhere that is relevant to the changes made here? |
Member
@AyodeAwe I'm taking this PR over. I'll update the description and re-request a review once it's ready. Putting it into draft for now. |
jameslamb
marked this pull request as draft
May 8, 2025 15:50
jameslamb
changed the title
This was referenced May 8, 2025
Closed
Member
|
I'm working on this in a replacement PR over here: #172 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of the changes to move Build Artifact storage from S3 (
downloads.rapids.ai) to the Github Artifact Store (see https://github.com/rapidsai/build-infra/issues/237).Made changes to the Github Authentication script, which now checks for authentication status rather than a token, and attempts to authenticate over HTTPS protocol if prior authentication is not found.