Skip to content

Fix package specifications - #424

Merged
ajschmidt8 merged 2 commits into
rapidsai:branch-22.02from
ajschmidt8:fix-pkg-specs
Jan 27, 2022
Merged

Fix package specifications#424
ajschmidt8 merged 2 commits into
rapidsai:branch-22.02from
ajschmidt8:fix-pkg-specs

Conversation

@ajschmidt8

Copy link
Copy Markdown
Member

After rapidsai/integration#411 was merged, the build string for our meta-packages changed from cuda11.5* to just cuda11*. This change caused our Docker builds to stop working.

Since we now build with CUDA Enhanced Compatibility, I think it should be fine to drop the =cuda spec from the strings below. However, an alternative would be to include the cudatoolkit spec as shown below, but I don't think that's necessary.

gpuci_mamba_retry install -n rapids \
  "rapids-notebook-env=${RAPIDS_VER}" \
  "cudatoolkit=${CUDA_VER}*" \
  && gpuci_conda_retry remove -y -n rapids --force-remove \
  "rapids-notebook-env=${RAPIDS_VER}*"

@ethyling, any thoughts here?

@ajschmidt8
ajschmidt8 requested a review from jjacobelli January 26, 2022 21:41
@ajschmidt8
ajschmidt8 requested a review from a team as a code owner January 26, 2022 21:41
@jjacobelli

Copy link
Copy Markdown
Contributor

After rapidsai/integration#411 was merged, the build string for our meta-packages changed from cuda11.5* to just cuda11*. This change caused our Docker builds to stop working.

Since we now build with CUDA Enhanced Compatibility, I think it should be fine to drop the =cuda spec from the strings below. However, an alternative would be to include the cudatoolkit spec as shown below, but I don't think that's necessary.

gpuci_mamba_retry install -n rapids \
  "rapids-notebook-env=${RAPIDS_VER}" \
  "cudatoolkit=${CUDA_VER}*" \
  && gpuci_conda_retry remove -y -n rapids --force-remove \
  "rapids-notebook-env=${RAPIDS_VER}*"

@ethyling, any thoughts here?

I think we can drop it for now, and add it later if needed

@ajschmidt8
ajschmidt8 merged commit da16459 into rapidsai:branch-22.02 Jan 27, 2022
@ajschmidt8
ajschmidt8 deleted the fix-pkg-specs branch January 27, 2022 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants