Support repository dependency_keys in manifest.yaml - #536
Merged
Conversation
Member
|
Every time you update one of the devcontainers features, you have to update the version to ensure it's published: I just pushed c82f309 doing that here. |
AyodeAwe
approved these changes
Jul 17, 2025
rapids-bot Bot
pushed a commit
to NVIDIA/cuml
that referenced
this pull request
Jul 18, 2025
Unified conda devcontainers use the `all` file key to generate their dependency lists for each repository. Currently cuml includes `xgboost` in its `all` file key via the `test_python` dependency list. Unfortunately, this pulls in a conda dependency on `librmm` via `libxgboost`. This is problematic because we must build `librmm` from source in our unified devcontainers. It seems like `xgboost` is a soft test dependency. In this PR, I add a new dependency file key called `devcontainers` that excludes `xgboost`. Developer conda environments, CI workflows, and pip devcontainers are unaffected by this change. Conda devcontainers will now require the user to manually install `xgboost` in order to run tests that need it, and this is noted in `BUILD.md`. This is needed to solve the problems discussed in rapidsai/devcontainers#534 (comment). Once this is merged, I will push a change to rapidsai/devcontainers#536 to use the new `devcontainers` file key. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - Paul Taylor (https://github.com/trxcllnt) - James Lamb (https://github.com/jameslamb) - Simon Adorf (https://github.com/csadorf) URL: #7006
bdice
added a commit
that referenced
this pull request
Jul 18, 2025
Follow-up to #536 now that NVIDIA/cuml#7006 is merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR isolates a change from @trxcllnt in #479 so that we can unblock CI on this repository.
We need this so we can exclude
xgboostfrom cuML's dependency list, sincelibxgboostbrings inlibrmmconda packages, and that breaks devcontainers building everything from source.Closes #535.
This temporarily breaks cuML devcontainers because it does not include the cuML test dependencies, but it unblocks cuML CI.
Planned follow-up actions:
devcontainerswith everything exceptxgboostmanifest.yamlto use that file key instead of the current set of keys (if the cuML PR merges first, we can modify this PR instead of needing a follow-up)