Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmarks: Add option to suppress output of point to point data #985

Merged
merged 2 commits into from
Sep 1, 2022

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Aug 31, 2022

When running with many workers the point to point data is not that
insightful, so add command-line flag to suppress it (default is still
to show data).

When running with many workers the point to point data is not that
insightful, so add command-line flag to suppress it (default is still
to show data).
@wence- wence- added 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Aug 31, 2022
@wence- wence- requested a review from a team as a code owner August 31, 2022 15:59
@github-actions github-actions bot added the python python code needed label Aug 31, 2022
@wence- wence- added improvement Improvement / enhancement to an existing function and removed python python code needed labels Aug 31, 2022
@codecov-commenter
Copy link

codecov-commenter commented Aug 31, 2022

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (660519b) compared to base (86a9846).
Patch has no changes to coverable lines.

❗ Current head 660519b differs from pull request most recent head 66d7f86. Consider uploading reports for the commit 66d7f86 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##           branch-22.10    #985    +/-   ##
=============================================
  Coverage          0.00%   0.00%            
=============================================
  Files                23      16     -7     
  Lines              3100    2109   -991     
=============================================
+ Misses             3100    2109   -991     
Impacted Files Coverage Δ
dask_cuda/benchmarks/utils.py
dask_cuda/benchmarks/local_cupy_map_overlap.py
dask_cuda/_version.py
dask_cuda/benchmarks/local_cudf_shuffle.py
dask_cuda/benchmarks/common.py
dask_cuda/benchmarks/local_cupy.py
dask_cuda/benchmarks/local_cudf_merge.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I think we can shorten the code quite a bit by only adding the --no-... option. Added suggestions for that.

dask_cuda/benchmarks/utils.py Outdated Show resolved Hide resolved
dask_cuda/benchmarks/utils.py Outdated Show resolved Hide resolved
dask_cuda/benchmarks/utils.py Outdated Show resolved Hide resolved
Co-authored-by: Peter Andreas Entschev <[email protected]>
@github-actions github-actions bot added the python python code needed label Sep 1, 2022
@wence-
Copy link
Contributor Author

wence- commented Sep 1, 2022

Looks good, but I think we can shorten the code quite a bit by only adding the --no-... option. Added suggestions for that.

Thanks, done.

Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @wence- !

@pentschev
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a34baea into rapidsai:branch-22.10 Sep 1, 2022
@wence- wence- deleted the wence/benchmark-detail branch September 1, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants