-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmarks: Add option to suppress output of point to point data #985
benchmarks: Add option to suppress output of point to point data #985
Conversation
When running with many workers the point to point data is not that insightful, so add command-line flag to suppress it (default is still to show data).
Codecov ReportBase: 0.00% // Head: 0.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## branch-22.10 #985 +/- ##
=============================================
Coverage 0.00% 0.00%
=============================================
Files 23 16 -7
Lines 3100 2109 -991
=============================================
+ Misses 3100 2109 -991 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but I think we can shorten the code quite a bit by only adding the --no-...
option. Added suggestions for that.
Co-authored-by: Peter Andreas Entschev <[email protected]>
Thanks, done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @wence- !
@gpucibot merge |
When running with many workers the point to point data is not that
insightful, so add command-line flag to suppress it (default is still
to show data).