Add __rmatmul__ to ProxyObject
#960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## branch-22.08 #960 +/- ##
============================================
Coverage 0.00% 0.00%
============================================
Files 16 16
Lines 2106 2108 +2
============================================
- Misses 2106 2108 +2
Continue to review full report at Codecov.
|
|
LGTM, thanks @jakirkham for working on this. cc @madsbk for awareness. |
|
@gpucibot merge |
pentschev
approved these changes
Jul 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #959
If another object (like a
cupy.ndarray) doesn't support__matmul__withProxyObject, Python will try to fallback to__rmatmul__. As__rmatmul__was not defined before (and some cases like with CuPy now raise), this would raise. To fix, that this PR defines__rmatmul__forProxyObjects to provide for this fallback layer.