-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REVIEW] Upgrade numba
pinning to be in-line with rest of rapids
#912
[REVIEW] Upgrade numba
pinning to be in-line with rest of rapids
#912
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @galipremsagar !
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #912 +/- ##
=============================================
Coverage 0.00% 0.00%
=============================================
Files 22 16 -6
Lines 3075 2094 -981
=============================================
+ Misses 3075 2094 -981 Continue to review full report at Codecov.
|
rerun tests |
@pentschev does the CI failure(a pytest timeout) look specific to this PR? |
I'm not quite sure to be honest, I actually have seen it fail in a few occasions. @madsbk do you think we need to increase the timeout for |
Let's try to increase the timeout, if it keep failing we can also skip it. |
Looks like increasing timeout worked, @pentschev | @madsbk could any one of you review the new changes? |
Thanks @galipremsagar and @madsbk ! |
@gpucibot merge |
This PR upgrades minimum version pinning of
numba
to0.54
from0.53.1
to be in-sync with rest of the rapids packages:https://github.com/rapidsai/integration/blob/branch-22.06/conda/recipes/versions.yaml#L114