Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REVIEW] Upgrade numba pinning to be in-line with rest of rapids #912

Merged
merged 2 commits into from
May 20, 2022

Conversation

galipremsagar
Copy link
Contributor

This PR upgrades minimum version pinning of numba to 0.54 from 0.53.1 to be in-sync with rest of the rapids packages:
https://github.com/rapidsai/integration/blob/branch-22.06/conda/recipes/versions.yaml#L114

@galipremsagar galipremsagar added improvement Improvement / enhancement to an existing function breaking Breaking change labels May 19, 2022
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @galipremsagar !

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022

Codecov Report

Merging #912 (2ae28cb) into branch-22.06 (497180d) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           branch-22.06    #912    +/-   ##
=============================================
  Coverage          0.00%   0.00%            
=============================================
  Files                22      16     -6     
  Lines              3075    2094   -981     
=============================================
+ Misses             3075    2094   -981     
Impacted Files Coverage Δ
dask_cuda/benchmarks/local_cudf_merge.py
dask_cuda/benchmarks/utils.py
dask_cuda/benchmarks/local_cudf_shuffle.py
dask_cuda/benchmarks/local_cupy.py
dask_cuda/_version.py
dask_cuda/benchmarks/local_cupy_map_overlap.py

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 497180d...2ae28cb. Read the comment docs.

@galipremsagar
Copy link
Contributor Author

rerun tests

@galipremsagar
Copy link
Contributor Author

@pentschev does the CI failure(a pytest timeout) look specific to this PR?

@pentschev
Copy link
Member

I'm not quite sure to be honest, I actually have seen it fail in a few occasions. @madsbk do you think we need to increase the timeout for test_worker_force_spill_to_disk or is it flaky for some reason?

@madsbk
Copy link
Member

madsbk commented May 20, 2022

I'm not quite sure to be honest, I actually have seen it fail in a few occasions. @madsbk do you think we need to increase the timeout for test_worker_force_spill_to_disk or is it flaky for some reason?

Let's try to increase the timeout, if it keep failing we can also skip it.
I am working on a complete new spilling approach, which hopefully makes all of this obsolete :)

@github-actions github-actions bot added the python python code needed label May 20, 2022
@galipremsagar
Copy link
Contributor Author

Looks like increasing timeout worked, @pentschev | @madsbk could any one of you review the new changes?

@pentschev
Copy link
Member

Thanks @galipremsagar and @madsbk !

@pentschev
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 10d83c9 into rapidsai:branch-22.06 May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change improvement Improvement / enhancement to an existing function python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants