Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip tests on import error for some optional packages #899

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Skip tests on import error for some optional packages #899

merged 1 commit into from
Apr 25, 2022

Conversation

pentschev
Copy link
Member

Packages such as rmm and dask_cudf are not requirements, thus we must ensure tests get skipped if they're not installed.

@pentschev pentschev added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change labels Apr 25, 2022
@pentschev pentschev requested a review from a team as a code owner April 25, 2022 10:48
@github-actions github-actions bot added the python python code needed label Apr 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-22.06@147043f). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff               @@
##             branch-22.06     #899   +/-   ##
===============================================
  Coverage                ?   89.49%           
===============================================
  Files                   ?       16           
  Lines                   ?     2094           
  Branches                ?        0           
===============================================
  Hits                    ?     1874           
  Misses                  ?      220           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 147043f...c967d56. Read the comment docs.

madsbk
madsbk approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pentschev
Copy link
Member Author

Thanks @madsbk !

@gpucibot merge

@pentschev
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 23c6e2d into rapidsai:branch-22.06 Apr 25, 2022
@pentschev pentschev deleted the fix-test-skip-imports branch April 26, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsbk madsbk madsbk approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change python python code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pentschev @codecov-commenter @madsbk