-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for RAPIDS_NO_INITIALIZE
#898
Add documentation for RAPIDS_NO_INITIALIZE
#898
Conversation
Codecov Report
@@ Coverage Diff @@
## branch-22.06 #898 +/- ##
=============================================
Coverage 89.49% 89.49%
=============================================
Files 16 16
Lines 2094 2094
=============================================
Hits 1874 1874
Misses 220 220
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, but I requested a few changes to make it more accurate and descriptive. Thanks @charlesbluca .
Co-authored-by: Peter Andreas Entschev <[email protected]>
Thanks @pentschev 🙂 think this should be ready for re-review / approval |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @charlesbluca !
@gpucibot merge |
Adds a warning to the UCX docs explaining the hazards of starting a CUDA context before initializing a UCX cluster, and how
RAPIDS_NO_INITIALIZE
can sometimes be used to avoid this.