Fix spill-to-disk triggered by Dask explicitly #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsbk
added
2 - In Progress
madsbk
changed the title
madsbk
changed the title
|
rerun tests |
Codecov Report
@@ Coverage Diff @@
## branch-21.12 #800 +/- ##
===============================================
Coverage ? 90.26%
===============================================
Files ? 15
Lines ? 1992
Branches ? 0
===============================================
Hits ? 1798
Misses ? 194
Partials ? 0 Continue to review full report at Codecov.
|
madsbk
added
3 - Ready for Review
|
@gpucibot merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The evict didn't use the
buffer_infointroduced in #779 and the test didn't capture the failure. This PR fixes both issues.Notice, I think this is small and important enough to go into the
v21.12release.