Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unittest.mock.patch for all os.environ tests #787

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

pentschev
Copy link
Member

Makes tests depending on os.environ settings less error-prone by applying changes via unittest.mock.patch that are automatically cleaned up.

@pentschev pentschev added 3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Nov 15, 2021
@pentschev pentschev requested a review from a team as a code owner November 15, 2021 15:14
@github-actions github-actions bot added the python python code needed label Nov 15, 2021
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Nov 15, 2021

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.12@731548c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.12     #787   +/-   ##
===============================================
  Coverage                ?   90.16%           
===============================================
  Files                   ?       15           
  Lines                   ?     1992           
  Branches                ?        0           
===============================================
  Hits                    ?     1796           
  Misses                  ?      196           
  Partials                ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 731548c...05fabb3. Read the comment docs.

@pentschev
Copy link
Member Author

Thanks @madsbk for the review!

@pentschev
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 7f00ee2 into rapidsai:branch-21.12 Nov 15, 2021
@pentschev pentschev deleted the mock-os-environ branch November 22, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants