Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --benchmark-json option to all benchmarks #700

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

charlesbluca
Copy link
Member

Makes --benchmark-json an option for all the benchmarks; also refactors the JSON dumping process so that the output file is a line-delimited JSON file, which can be appended to by subsequent runs of the benchmark script. This makes it a lot easier to process the output in Pandas with something like

pd.read_json("benchmark.json", lines=True)

Also added the device_memory_limit option to the printed output of the scripts, so that it is visible if specified.

@charlesbluca charlesbluca added python python code needed 3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change labels Aug 9, 2021
@charlesbluca charlesbluca requested a review from a team as a code owner August 9, 2021 17:01
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

LGTM, thanks @charlesbluca !

@pentschev
Copy link
Member

@gpucibot merge

@rapids-bot rapids-bot bot merged commit a44d0b8 into rapidsai:branch-21.10 Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants