Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dot calling style for pytest #661

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Remove dot calling style for pytest #661

merged 1 commit into from
Jun 23, 2021

Conversation

quasiben
Copy link
Member

Addresses @ajschmidt8 comments in #658 (comment)

@quasiben quasiben requested a review from a team as a code owner June 23, 2021 14:50
@github-actions github-actions bot added the gpuCI gpuCI issue label Jun 23, 2021
@quasiben quasiben added 5 - Ready to Merge Testing and reviews complete, ready to merge non-breaking Non-breaking change improvement Improvement / enhancement to an existing function and removed gpuCI gpuCI issue labels Jun 23, 2021
madsbk
madsbk approved these changes Jun 23, 2021
View reviewed changes
Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, looks much better :)

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2021 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (branch-21.08@0a221ec). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff               @@
##             branch-21.08     #661   +/-   ##
===============================================
  Coverage                ?   90.32%           
===============================================
  Files                   ?       15           
  Lines                   ?     1644           
  Branches                ?        0           
===============================================
  Hits                    ?     1485           
  Misses                  ?      159           
  Partials                ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a221ec...26f8e83. Read the comment docs.

@quasiben
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit bc23031 into rapidsai:branch-21.08 Jun 23, 2021
@quasiben quasiben deleted the fix-pytest-call branch June 23, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsbk madsbk madsbk approved these changes

@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes

Assignees
No one assigned
Labels
5 - Ready to Merge Testing and reviews complete, ready to merge improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@quasiben @codecov-commenter @madsbk @ajschmidt8