Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and test with CUDA 12.5.1 #1357

Merged
merged 4 commits into from
Jul 16, 2024

Conversation

KyleFromNVIDIA
Copy link
Contributor

@KyleFromNVIDIA KyleFromNVIDIA commented Jul 11, 2024

This PR updates the latest CUDA build/test version 12.2.2 to 12.5.1.

Contributes to rapidsai/build-planning#73

@KyleFromNVIDIA KyleFromNVIDIA added non-breaking Non-breaking change improvement Improvement / enhancement to an existing function labels Jul 11, 2024
@github-actions github-actions bot added the conda conda issue label Jul 11, 2024
@KyleFromNVIDIA KyleFromNVIDIA marked this pull request as ready for review July 16, 2024 13:27
@KyleFromNVIDIA KyleFromNVIDIA requested review from a team as code owners July 16, 2024 13:27
@jameslamb jameslamb requested review from jameslamb and removed request for AyodeAwe July 16, 2024 15:02
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should update this too, to encourage use of newer CUDA versions:

To install the latest version of Dask-CUDA along with CUDA Toolkit 12.0:
.. code-block:: bash
conda install -c rapidsai -c conda-forge -c nvidia dask-cuda cuda-version=12.0

I've now seen a couple like that:

rapidsai/raft#2378 (review)

rapidsai/cuvs#219 (review)

None are technically "wrong", as they say "for CUDA 12.0...", but they all use only a single minor version (e.g. there's no "for CUDA 12.2...", "for CUDA 12.3...", etc.), so I think the intent is to be up to date with the latest minor version supported across RAPIDS.

It think it'd be worth adding rules like the following to the rapids-reviser migration.

For any .md or .rst file:

  • replace CUDA 12.[0-9]+ with CUDA 12.{target_version}
  • replace cuda-version=12.[0-9]+ with cuda-version=12.{target_version}

@jameslamb
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit c31aaac into rapidsai:branch-24.08 Jul 16, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conda conda issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants