Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path #1277

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Fix path #1277

merged 1 commit into from
Nov 16, 2023

Conversation

vyasr
Copy link
Contributor

@vyasr vyasr commented Nov 16, 2023

The package_name variable was not set here, so the git commit was never actually overwritten.

@vyasr vyasr added bug Something isn't working non-breaking Non-breaking change labels Nov 16, 2023
@vyasr vyasr self-assigned this Nov 16, 2023
@vyasr vyasr requested a review from a team as a code owner November 16, 2023 02:00
@github-actions github-actions bot added the ci label Nov 16, 2023
@vyasr
Copy link
Contributor Author

vyasr commented Nov 16, 2023

/merge

@rapids-bot rapids-bot bot merged commit 21e11bf into rapidsai:branch-23.12 Nov 16, 2023
23 checks passed
@vyasr vyasr deleted the fix/git_commit_overwrite branch November 16, 2023 02:46
younseojava pushed a commit to ROCm/dask-cuda-rocm that referenced this pull request Apr 16, 2024
The `package_name` variable was not set here, so the git commit was never actually overwritten.

Authors:
  - Vyas Ramasubramani (https://github.com/vyasr)

Approvers:
  - Ray Douglass (https://github.com/raydouglass)

URL: rapidsai#1277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants