Generate proper, consistent nightly versions for pip and conda packages #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
galipremsagar
added
improvement
vyasr
requested changes
Oct 27, 2023
There was a problem hiding this comment.
You also need to specify that the VERSION file should be included in the built distributions. Since dask-cuda uses setuptools directly, you can specify that in MANIFEST.in.
|
Please see this comment: #1267 (review) |
Thanks for pointing me to this John. @vyasr Apologies I missed it the first time. |
vyasr
approved these changes
Oct 27, 2023
jakirkham
approved these changes
Oct 27, 2023
raydouglass
approved these changes
Oct 27, 2023
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes conda Python packages and wheels to all generate a consistent version for nightlies. The nightly version is of the form YY.MM.DDaN, where N is the number of commits from the last tag. The version is embedded in both the package metadata and in the
dask_cuda.__version__attribute. In addition the commit hash itself is embedded into the package asdask_cuda.__git_commit__. These changes ensure that