Update plugins to inherit from WorkerPlugin
#1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @rjzamora @jacobtomlinson as this came up in a meeting earlier today |
rjzamora
added
bug
|
Thanks @jrbourbeau ! |
|
Btw, I'm not super familiar with the codebase here. So just let me know if there are other plugins around |
|
/ok to test |
|
/ok to test |
|
/ok to test |
|
/ok to test |
pentschev
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
LGTM, thanks @jrbourbeau for helping us out with getting Dask-CUDA up-to-speed with latest Distributed changes!
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream in
distributedwe're considering enforcing plugins to inherit from their respective base class (e.g.WorkerPlugin,SchedulerPlugin,NannyPlugin) dask/distributed#8149. This PR updates plugins here to inherhit fromWorkerPlugin. This makes things a little more future-proof and is probably a good thing to do anyways.