Clarify memory_limit docs
#1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pentschev
added
3 - Ready for Review
galipremsagar
approved these changes
Jul 1, 2023
rnyak
reviewed
Jul 3, 2023
| (bytes), float (fraction of total system memory), string (like ``"5GB"`` or | ||
| ``"5000M"``), or ``"auto"`` or 0 for no memory management.""", | ||
| help="""Size of the host LRU cache, which is used to determine when the worker | ||
| starts spilling to disk (not available if JIT-Unspill is enabled). Can be an |
There was a problem hiding this comment.
is there any dependency between memory-limit and device-memory-limit, that should be set? like if one cannot be bigger than other etc..
There was a problem hiding this comment.
memory-limit and device-memory-limit are independent
|
Thanks everyone for reviews. @rnyak if you have further suggestions to improve phrasing, please feel free to open an issue or a PR with changes. |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not currently clear what is the purpose of
memory_limit/--memory-limit. This attempts to clarify it's used to spill from host memory to disk.