Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reinstate --death-timeout CLI option #1140

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Reinstate --death-timeout CLI option #1140

merged 2 commits into from
Mar 13, 2023

Conversation

charlesbluca
Copy link
Member

Add back in the --death-timeout option removed in #563, along with some tests to verify it's working as expected.

Closes #1017

@charlesbluca charlesbluca requested a review from a team as a code owner March 13, 2023 18:28
@github-actions github-actions bot added the python python code needed label Mar 13, 2023
@charlesbluca charlesbluca added 3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change labels Mar 13, 2023
pentschev
pentschev approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @charlesbluca !

@pentschev
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit ec2de78 into rapidsai:branch-23.04 Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pentschev pentschev pentschev approved these changes

Assignees
No one assigned
Labels
3 - Ready for Review Ready for review by team feature request New feature or request non-breaking Non-breaking change python python code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reinstate --death-timeout
2 participants
@charlesbluca @pentschev