Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explicit-comms: don't mix - and _ in config #1096

Merged
merged 3 commits into from
Jan 31, 2023

Conversation

madsbk
Copy link
Member

@madsbk madsbk commented Jan 30, 2023

Using dask.config.get("explicit_comms-batchsize", 1) doesn't read DASK_EXPLICIT_COMMS_BATCHSIZE correctly.

@madsbk madsbk added bug Something isn't working non-breaking Non-breaking change labels Jan 30, 2023
@github-actions github-actions bot added the python python code needed label Jan 30, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 87.90% // Head: 87.91% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (39d88f5) compared to base (66a6a46).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-23.02    #1096      +/-   ##
================================================
+ Coverage         87.90%   87.91%   +0.01%     
================================================
  Files                17       17              
  Lines              2298     2300       +2     
================================================
+ Hits               2020     2022       +2     
  Misses              278      278              
Impacted Files Coverage Δ
dask_cuda/cli.py 86.40% <ø> (ø)
dask_cuda/disk_io.py 56.19% <ø> (ø)
dask_cuda/initialize.py 87.23% <ø> (ø)
dask_cuda/is_spillable_object.py 84.37% <ø> (ø)
dask_cuda/proxy_object.py 90.52% <ø> (ø)
dask_cuda/utils.py 83.47% <ø> (ø)
dask_cuda/explicit_comms/dataframe/shuffle.py 98.69% <100.00%> (+0.01%) ⬆️
dask_cuda/proxify_device_objects.py 97.32% <100.00%> (ø)
dask_cuda/proxify_host_file.py 93.71% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@madsbk madsbk marked this pull request as ready for review January 30, 2023 19:56
@madsbk madsbk requested a review from a team as a code owner January 30, 2023 19:56
Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @madsbk , but I think there's room to improve how explicit comms are organized. WDYT?

batchsize = batchsize or dask.config.get("explicit_comms-batchsize", 1)
batchsize = batchsize or dask.config.get("explicit-comms-batchsize", 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given there are multiple properties for explicit-comms (i.e., explicit-comms and explicit-comms-batchsize), I think it would make sense to make that a collection, e.g., explicit-comms.enable and explicit-comms.batchsize, or something analogous.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I advocated for this in a previous PR, so I am in favour of this idea.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, yes @wence- had the exact same suggestion: #1068 (comment) :)

I will change to explicit-comms.enable in a follow up PR

@madsbk
Copy link
Member Author

madsbk commented Jan 31, 2023

/merge

@rapids-bot rapids-bot bot merged commit 0628f05 into rapidsai:branch-23.02 Jan 31, 2023
@madsbk madsbk deleted the batchsize_config branch January 31, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change python python code needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants