Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add initial docs build #1089

Merged
merged 2 commits into from
Jan 20, 2023
Merged

Conversation

AjayThorve
Copy link
Member

The PR adds a docs_build process to the PR and Build workflows for this repository. The generated docs are synced to s3 for only the build workflows.

cc @ajschmidt8

@AjayThorve AjayThorve requested a review from a team as a code owner January 19, 2023 19:24
@github-actions github-actions bot added the gpuCI gpuCI issue label Jan 19, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2023

Codecov Report

Base: 87.04% // Head: 87.89% // Increases project coverage by +0.84% 🎉

Coverage data is based on head (48f0814) compared to base (2c88933).
Patch coverage: 72.50% of modified lines in pull request are covered.

❗ Current head 48f0814 differs from pull request most recent head 6edfd1e. Consider uploading reports for the commit 6edfd1e to get more accurate results

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-23.02    #1089      +/-   ##
================================================
+ Coverage         87.04%   87.89%   +0.84%     
================================================
  Files                18       17       -1     
  Lines              2301     2296       -5     
================================================
+ Hits               2003     2018      +15     
+ Misses              298      278      -20     
Impacted Files Coverage Δ
dask_cuda/cuda_worker.py 77.92% <ø> (ø)
dask_cuda/initialize.py 87.23% <ø> (ø)
dask_cuda/cli.py 86.40% <72.50%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@pentschev pentschev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if I missed some previous conversation on this subject, but does this mean we won't use RTD anymore for documentation?

@ajschmidt8
Copy link
Member

Sorry if I missed some previous conversation on this subject, but does this mean we won't use RTD anymore for documentation?

@pentschev, this PR adds documentation building to our GitHub Action workflows.

Previously, the doc build jobs lived in Jenkins, but we need to get them migrated to GHAs since Jenkins is going away.

The changes in this PR don't change any themes or frameworks used by dask-cuda, they only add the build process to GHAs.

@ajschmidt8 ajschmidt8 added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 19, 2023
@pentschev
Copy link
Member

Thanks for clarifying @ajschmidt8 .

@ajschmidt8
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit e9609c6 into rapidsai:branch-23.02 Jan 20, 2023
@AjayThorve AjayThorve deleted the add-docs-build branch January 20, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gpuCI gpuCI issue improvement Improvement / enhancement to an existing function non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants