Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch pre-import not found test to sync definition #1026

Merged

Conversation

pentschev
Copy link
Member

Even though pytest-async is installed, it has not executed async tests that aren't wrapped in gen_cluster. Using gen_cluster is the proper way for Dask testing, but in few exceptions we may not be able to use it, such as when cleanup must be avoided.

Even though pytest-async is installed, it has not executed async tests
that aren't wrapped in gen_cluster. Using gen_cluster is the proper way
for Dask testing, but in few exceptions we may not be able to use it,
such as when cleanup must be avoided.
@pentschev pentschev requested a review from a team as a code owner October 28, 2022 10:24
@github-actions github-actions bot added the python python code needed label Oct 28, 2022
@pentschev pentschev added bug Something isn't working 3 - Ready for Review Ready for review by team non-breaking Non-breaking change and removed python python code needed labels Oct 28, 2022
@pentschev
Copy link
Member Author

@madsbk this should fix CI failures seen in #1025 .

@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2022

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (b910eb9) compared to base (99894b1).
Patch has no changes to coverable lines.

❗ Current head b910eb9 differs from pull request most recent head da2a254. Consider uploading reports for the commit da2a254 to get more accurate results

Additional details and impacted files
@@              Coverage Diff               @@
##           branch-22.12   #1026     +/-   ##
==============================================
  Coverage          0.00%   0.00%             
==============================================
  Files                25      17      -8     
  Lines              3315    2214   -1101     
==============================================
+ Misses             3315    2214   -1101     
Impacted Files Coverage Δ
dask_cuda/benchmarks/local_cudf_groupby.py
dask_cuda/benchmarks/local_cudf_shuffle.py
dask_cuda/benchmarks/local_cupy_map_overlap.py
dask_cuda/benchmarks/local_cudf_merge.py
dask_cuda/benchmarks/utils.py
dask_cuda/_version.py
dask_cuda/benchmarks/local_cupy.py
dask_cuda/benchmarks/common.py

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@madsbk madsbk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks @pentschev

@madsbk
Copy link
Member

madsbk commented Oct 28, 2022

@gpucibot merge

1 similar comment
@pentschev
Copy link
Member Author

@gpucibot merge

@rapids-bot rapids-bot bot merged commit 91d605c into rapidsai:branch-22.12 Oct 28, 2022
@pentschev
Copy link
Member Author

Thanks Mads, not sure why gpuCI didn't merge after your comment.

@madsbk
Copy link
Member

madsbk commented Oct 28, 2022

Did I lose my mojo? :)

@pentschev
Copy link
Member Author

Did I lose my mojo? :)

Doesn't look like it, the important part (approving) was accepted. No idea what happened... 🤷

@pentschev pentschev deleted the fix-pre-import-async-test branch October 28, 2022 13:00
@pentschev pentschev mentioned this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Ready for Review Ready for review by team bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants