-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch pre-import not found test to sync definition #1026
Switch pre-import not found test to sync definition #1026
Conversation
Even though pytest-async is installed, it has not executed async tests that aren't wrapped in gen_cluster. Using gen_cluster is the proper way for Dask testing, but in few exceptions we may not be able to use it, such as when cleanup must be avoided.
Codecov ReportBase: 0.00% // Head: 0.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## branch-22.12 #1026 +/- ##
==============================================
Coverage 0.00% 0.00%
==============================================
Files 25 17 -8
Lines 3315 2214 -1101
==============================================
+ Misses 3315 2214 -1101 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks @pentschev
@gpucibot merge |
1 similar comment
@gpucibot merge |
Thanks Mads, not sure why gpuCI didn't merge after your comment. |
Did I lose my mojo? :) |
Doesn't look like it, the important part (approving) was accepted. No idea what happened... 🤷 |
Even though pytest-async is installed, it has not executed async tests that aren't wrapped in gen_cluster. Using gen_cluster is the proper way for Dask testing, but in few exceptions we may not be able to use it, such as when cleanup must be avoided.