Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run NumPy 2 ruff fixes (changing NaN to nan) #606

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

seberg
Copy link
Contributor

@seberg seberg commented Jul 3, 2024

This just fixes a simple error that would appear when run with NumPy 2 based on the ruff check.
(This does not mean there are no other issues.)

xref: rapidsai/build-planning#38

This just fixes a simple error that would appear when run with NumPy 2
based on the ruff check.
(This does not mean there are no other issues.)
@seberg seberg requested a review from a team as a code owner July 3, 2024 11:36
@github-actions github-actions bot added the Python label Jul 3, 2024
@jakirkham jakirkham added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jul 10, 2024
@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 14237a1 into rapidsai:branch-24.08 Jul 10, 2024
30 checks passed
@jakirkham
Copy link
Member

Thanks all! 🙏

@seberg seberg deleted the numpy2-ruff branch July 10, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement / enhancement to an existing function non-breaking Non-breaking change Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants