Skip to content

run shellcheck on all files, other small pre-commit updates#865

Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.06from
jameslamb:ci/more-shellcheck
May 2, 2025
Merged

run shellcheck on all files, other small pre-commit updates#865
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.06from
jameslamb:ci/more-shellcheck

Conversation

@jameslamb
Copy link
Member

Contributes to rapidsai/build-planning#135

Follow-up to #662

While reviewing #805 and #831, I found myself suggesting things manually that I know shellcheck would have caught automatically. To prevent that for reviewers in the future, this proposes running shellcheck on all shell scripts in the repo, not just those in the ci/ directory.

Other changes:

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels May 1, 2025
@jameslamb jameslamb requested review from a team as code owners May 1, 2025 19:20
@jameslamb jameslamb requested a review from bdice May 1, 2025 19:20
@github-actions github-actions bot added the cpp label May 1, 2025
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 7bc467a into rapidsai:branch-25.06 May 2, 2025
68 checks passed
@jameslamb jameslamb deleted the ci/more-shellcheck branch May 2, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cpp improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants