run shellcheck on all files, other small pre-commit updates#865
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.06from May 2, 2025
jameslamb:ci/more-shellcheck
Merged
run shellcheck on all files, other small pre-commit updates#865rapids-bot[bot] merged 1 commit intorapidsai:branch-25.06from jameslamb:ci/more-shellcheck
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.06from
jameslamb:ci/more-shellcheck
Conversation
bdice
approved these changes
May 1, 2025
benfred
approved these changes
May 2, 2025
Member
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to rapidsai/build-planning#135
Follow-up to #662
While reviewing #805 and #831, I found myself suggesting things manually that I know
shellcheckwould have caught automatically. To prevent that for reviewers in the future, this proposes runningshellcheckon all shell scripts in the repo, not just those in theci/directory.Other changes:
rapids-dependency-file-generatorto its latest version (1.18.1).pre-commit-config.yaml