add runtime dependency on libcuvs in cuvs wheels#615
Merged
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.02from Jan 24, 2025
jameslamb:fix/cuvs-libcuvs-dep
Merged
add runtime dependency on libcuvs in cuvs wheels#615rapids-bot[bot] merged 1 commit intorapidsai:branch-25.02from jameslamb:fix/cuvs-libcuvs-dep
rapids-bot[bot] merged 1 commit intorapidsai:branch-25.02from
jameslamb:fix/cuvs-libcuvs-dep
Conversation
jameslamb
added
bug
vyasr
approved these changes
Jan 24, 2025
Member
Author
|
/merge |
narangvivek10
pushed a commit
to SearchScale/cuvs
that referenced
this pull request
Jan 27, 2025
`cuvs-cu{11,12}` wheels don't currently have a runtime dependency on `libcuvs-cu{11,12}`. They need one, for library-loading:
https://github.com/rapidsai/cuvs/blob/e9983e17408e6bec6f2558f9df49be97a7255417/python/cuvs/cuvs/__init__.py#L19-L25
This was missed in rapidsai#594. This PR adds it.
## Notes for Reviewers
Adding for searchability... this bug can result in issues like this at runtime when using `cuvs` installed from wheels:
> ImportError: libcuvs_c.so: cannot open shared object file: No such file or directory
Authors:
- James Lamb (https://github.com/jameslamb)
Approvers:
- Vyas Ramasubramani (https://github.com/vyasr)
URL: rapidsai#615
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cuvs-cu{11,12}wheels don't currently have a runtime dependency onlibcuvs-cu{11,12}. They need one, for library-loading:cuvs/python/cuvs/cuvs/__init__.py
Lines 19 to 25 in e9983e1
This was missed in #594. This PR adds it.
Notes for Reviewers
Adding for searchability... this bug can result in issues like this at runtime when using
cuvsinstalled from wheels: