Fix include errors, header, and unsafe locks in iface.hpp#467
Merged
rapids-bot[bot] merged 5 commits intorapidsai:branch-24.12from Nov 14, 2024
Merged
Fix include errors, header, and unsafe locks in iface.hpp#467rapids-bot[bot] merged 5 commits intorapidsai:branch-24.12from
rapids-bot[bot] merged 5 commits intorapidsai:branch-24.12from
Conversation
achirkin
added
bug
viclafargue
approved these changes
Nov 14, 2024
Contributor
viclafargue
left a comment
viclafargue
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot for looking into this @achirkin!
cjnolet
approved these changes
Nov 14, 2024
benfred
approved these changes
Nov 14, 2024
Member
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a few issues with the internal header
neighbors/iface/iface.hppleading to compile time errors and dangerous runtime behavior:std::lock_guardto avoid a deadlock on exception