Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NumPy <2 pin #297

Merged
merged 6 commits into from
Aug 24, 2024
Merged

Remove NumPy <2 pin #297

merged 6 commits into from
Aug 24, 2024

Conversation

seberg
Copy link
Contributor

@seberg seberg commented Aug 19, 2024

This PR removes the NumPy<2 pin which is expected to work for
RAPIDS projects once CuPy 13.3.0 is released (CuPy 13.2.0 had
some issues preventing the use with NumPy 2).

@seberg seberg added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Aug 19, 2024
@seberg seberg mentioned this pull request Aug 19, 2024
Closed
jakirkham
jakirkham reviewed Aug 22, 2024
View reviewed changes
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sebastian! 🙏

Had a suggestion below

python/cuvs/pyproject.toml Show resolved Hide resolved
@seberg seberg marked this pull request as ready for review August 22, 2024 19:45
@seberg seberg requested a review from a team as a code owner August 22, 2024 19:45
@seberg seberg requested a review from msarahan August 22, 2024 19:45
@jameslamb jameslamb requested review from jameslamb and removed request for msarahan August 22, 2024 19:47
@jakirkham
Copy link
Member

Pushed a small change to line up the dependencies across conda and wheels. Hope that is ok

As this depends on RAFT, CI may fail until we get PR ( rapidsai/raft#2414 ) through. We can restart after that is done

@jameslamb
Copy link
Member

Some jobs were failing with what looked like temporary network errors, so I restarted CI here.

@jakirkham jakirkham closed this Aug 23, 2024
@jakirkham jakirkham reopened this Aug 23, 2024
@jakirkham
Copy link
Member

Restarting CI now that RAFT has been rebuilt with NumPy 2 support: rapidsai/raft#2414

@seberg
Copy link
Contributor Author

seberg commented Aug 23, 2024

Nice, seems like this is passing now and using NumPy 2.0.1 (I also briefly scanned the code to see if the most likely NumPy 2.1 change can't affect it -- related to np.full/copyto with python integers).

jameslamb
jameslamb approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I double-checked that there's no need for a build dependency on numpy here, that the cuda-python dependency added is necessary, and that we're seeing numpy 2.x in tests.

@jakirkham
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 49e45bb into rapidsai:branch-24.10 Aug 24, 2024
46 checks passed
@jakirkham
Copy link
Member

Thanks Sebastian and James! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakirkham jakirkham jakirkham left review comments

@jameslamb jameslamb jameslamb approved these changes

Assignees
No one assigned
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change Python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seberg @jakirkham @jameslamb