[WIP][Java] Add libcuvs version check#1315
[WIP][Java] Add libcuvs version check#1315ldematte wants to merge 2 commits intorapidsai:pull-request/1314from
libcuvs version check#1315Conversation
github-project-automation
bot
moved this to Todo
in Vector Search, ML, & Data Mining Release Board
cjnolet
added
improvement
|
For the record, I took this change (and #1314) out for a spin with #1296. The patches don't apply completely cleanly, but they are easy enough to resolve. Things seem to work. These changes are compatible with #1296. I also tested changing the version, to see if the incompatibility is detected. That works as well. |
github-project-automation
bot
moved this from Todo
to Done
in Vector Search, ML, & Data Mining Release Board
|
@mythrocks I don't understand why this was closed.. can you help? |
|
Hmm. I don't get this either. It's not allowing me to reopen it either. Very odd. |
mythrocks
moved this from Done
to In Progress
in Vector Search, ML, & Data Mining Release Board
|
Nope, no dice. The Github UI says that the branch Please feel free to raise another PR with the same branch. It's already been reviewed, so it shouldn't be controversial to get it in. |
|
Ah, I see that this PR was raised against |
yep, I wanted to change it to branch-25.10 but it does not let you do that when the PR is closed, and if it is closed again as soon as you re-open it... |
|
I've create #1327 to replace this |
This PR extends #1314 to add version check (version reported by libcuvs vs. cuvs-java build version) It replaces #1315 which was already reviewed and approved, but got closed before I could rebase it. Authors: - Lorenzo Dematté (https://github.com/ldematte) Approvers: - MithunR (https://github.com/mythrocks) URL: #1327
cjnolet
moved this from In Progress
to Done
in Vector Search, ML, & Data Mining Release Board
4 participants
This PR extends #1314 to add version check (version reported by libcuvs vs. cuvs-java build version)