This repository was archived by the owner on Jul 28, 2025. It is now read-only.
Update Documentation with Pydata Sphinx Theme, and more - #523
Merged
Merged
Conversation
github-actions
Bot
added
conda
isVoid
added
documentation
doc
Contributor
Author
|
Front page: |
harrism
suggested changes
May 11, 2022
Comment on lines
+18
to
+19
| cuSpatial proposes a new GeoArrow format from the fruit of discussions | ||
| with the GeoPandas team. GeoArrow is a packed columnar data format |
Member
There was a problem hiding this comment.
GeoArrow exists independently of cuSpatial. This makes it sound like we invented GeoArrow. I don't think this sentence belongs in our documentation. (CC @thomcom )
Suggested change
| cuSpatial proposes a new GeoArrow format from the fruit of discussions | |
| with the GeoPandas team. GeoArrow is a packed columnar data format | |
| GeoArrow is a packed columnar data format |
Contributor
There was a problem hiding this comment.
That's fine. I had the first implementation, though GeoArrow diverged from my implementation a little as per the previous discussions. :D :D
ajschmidt8
approved these changes
May 11, 2022
ajschmidt8
left a comment
ajschmidt8
left a comment
Member
There was a problem hiding this comment.
Approving ops-codeowner file changes
Co-authored-by: Mark Harris <mharris@nvidia.com>
github-actions
Bot
added
conda
Contributor
Author
|
Thanks to @ajschmidt8 , the documentation is now live for review at https://627d5be4c229560ba620c84d--docs-rapids-ai.netlify.app/api/cuspatial/nightly/ ! |
This was referenced May 12, 2022
harrism
reviewed
May 16, 2022
harrism
approved these changes
May 18, 2022
Member
|
@thomcom could you please review this PR? |
thomcom
approved these changes
May 27, 2022
Comment on lines
+74
to
+87
| "mlines": | ||
| [1, 3] | ||
| }) | ||
|
|
||
| Which encodes a GeoPandas Series:: | ||
|
|
||
| series = geopandas.Series([ | ||
| LineString((0, 0), (0, 1), (0, 2)), | ||
| MultiLineString([(1, 0), (1, 1), (1, 2)], | ||
| [(2, 0), (2, 1), (2, 2)], | ||
| ) | ||
| LineString((3, 0), (3, 1), (3, 2)), | ||
| LineString((4, 0), (4, 1), (4, 2)), | ||
| ]) |
Contributor
There was a problem hiding this comment.
Heya, sorry for not being in this convo earlier. I'll be looking into dropping the 'bounding regions' in the mlines object to fit GeoArrow format correctly.
Member
|
@gpucibot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #459 . It updates the sphinx theme with
Pydata-sphinx-theme.Besides this PR also:
internals.rstto focus on discussing GeoArrow format. Shuffled around the docstrings forGeoArrowBufferand make background description and API usage relatively independent, but all presented in the same page for shared context.from_geopandasdocstring.