Skip to content
This repository was archived by the owner on Jul 28, 2025. It is now read-only.

[REVIEW] Pin gdal to be compatible with cuxfilter - #245

Merged
thomcom merged 4 commits into
rapidsai:branch-0.15from
raydouglass:gdal-version
Jun 16, 2020
Merged

[REVIEW] Pin gdal to be compatible with cuxfilter#245
thomcom merged 4 commits into
rapidsai:branch-0.15from
raydouglass:gdal-version

Conversation

@raydouglass

@raydouglass raydouglass commented Jun 15, 2020

Copy link
Copy Markdown
Contributor

cuxfilter has a dependency on geopandas which seems to be locked to gdal 3.0.x.

@raydouglass
raydouglass requested a review from a team as a code owner June 15, 2020 21:14
@raydouglass raydouglass self-assigned this Jun 15, 2020
@GPUtester

GPUtester commented Jun 15, 2020

Copy link
Copy Markdown
Contributor

Please update the changelog in order to start CI tests.

View the gpuCI docs here.

@mike-wendt

mike-wendt commented Jun 15, 2020

Copy link
Copy Markdown
Contributor

rerun tests

@mike-wendt

mike-wendt commented Jun 15, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Not sure why that pulled gdal 3.1.0 with the spec of >=3.0.2,<3.1.0a - retrying the builds

@mike-wendt

mike-wendt commented Jun 15, 2020

Copy link
Copy Markdown
Contributor

Not sure why that pulled gdal 3.1.0 with the spec of >=3.0.2,<3.1.0a - retrying the builds
Figure this out, needed to merge rapidsai/integration#53 and rebuild updated env pkgs - this is done now and should pass

@raydouglass

raydouglass commented Jun 15, 2020

Copy link
Copy Markdown
Contributor Author

rerun tests

@mike-wendt

mike-wendt commented Jun 16, 2020

Copy link
Copy Markdown
Contributor

Should be GTG now with the above commit

@harrism

harrism commented Jun 16, 2020

Copy link
Copy Markdown
Member

I would like @thomcom to approve before merging.

@harrism
harrism requested a review from thomcom June 16, 2020 00:42
@harrism harrism added the 3 - Ready for Review Ready for review by team label Jun 16, 2020
thomcom
thomcom approved these changes Jun 16, 2020
View reviewed changes

@thomcom thomcom left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks lgtm

@thomcom
thomcom merged commit de1e443 into rapidsai:branch-0.15 Jun 16, 2020
@weiji14 weiji14 mentioned this pull request Dec 4, 2020
Closed
@weiji14 weiji14 mentioned this pull request Jan 13, 2021
Merged
rapids-bot Bot pushed a commit that referenced this pull request Jan 15, 2021
@weiji14
Pin gdal to 3.1.x(#339)
871c991 
Bump `gdal` from 3.0.x to 3.1.x, fixes #327 and supersedes/reverts #245.

Authors:
  - Wei Ji <weiji.leong@vuw.ac.nz>
  - Keith Kraus <kkraus@nvidia.com>

Approvers:
  - Keith Kraus (@kkraus14)
  - AJ Schmidt (@ajschmidt8)

URL: #339
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers
@thomcom thomcom thomcom approved these changes
@mike-wendt mike-wendt mike-wendt approved these changes
@ajschmidt8 ajschmidt8 ajschmidt8 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@raydouglass raydouglass

Labels

3 - Ready for Review Ready for review by team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@raydouglass @GPUtester @mike-wendt @harrism @thomcom @ajschmidt8