Skip to content

Remove import of scalar_broadcast_to from stemmer #4706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 4 commits into from
May 3, 2022
Merged

Remove import of scalar_broadcast_to from stemmer #4706

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
af69e82
Remove import of scalar_broadcast_to from cuDF
viclafargue Apr 22, 2022
421ed32
Update header
viclafargue Apr 25, 2022
4c7f7fc
Fix
viclafargue Apr 25, 2022
b60bf08
FIX xfail test_hashingvectorizer_alternate_sign to unblock CI
dantegd May 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions python/cuml/preprocessing/text/stem/porter_stemmer_utils/suffix_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# Copyright (c) 2020, NVIDIA CORPORATION.
# Copyright (c) 2020-2022, NVIDIA CORPORATION.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
Expand All @@ -18,15 +18,14 @@
import cudf
import numpy as np
import cupy as cp
from cudf.utils.utils import scalar_broadcast_to


def get_str_replacement_series(replacement, bool_mask):
"""
Get replacement series with replacement at
Places marked by bool mask and empty other wise
"""
word_ser = cudf.Series(scalar_broadcast_to("", size=len(bool_mask)))
word_ser = cudf.Series(cudf.core.column.full(len(bool_mask), ""))
word_ser.iloc[bool_mask] = replacement

return word_ser
Expand Down
1 change: 1 addition & 0 deletions python/cuml/tests/test_text_feature_extraction.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,7 @@ def test_hashingvectorizer_norm(norm):
assert_almost_equal_hash_matrices(res.todense().get(), ref.toarray())


@pytest.mark.xfail(reason="https://github.com/rapidsai/cuml/issues/4721")
def test_hashingvectorizer_alternate_sign():
# if alternate_sign = True
# we should have some negative and positive values
Expand Down