[REVIEW] Update to use __reduce_ex__ in CumlArray to override cudf.Buffer#2228
Merged
dantegd merged 6 commits intorapidsai:branch-0.14from May 11, 2020
Merged
[REVIEW] Update to use __reduce_ex__ in CumlArray to override cudf.Buffer#2228dantegd merged 6 commits intorapidsai:branch-0.14from
dantegd merged 6 commits intorapidsai:branch-0.14from
Conversation
dantegd
added
3 - Ready for Review
dantegd
changed the title
Contributor
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
Member
Author
|
rerun tests |
jakirkham
reviewed
May 10, 2020
python/cuml/common/array.py
Outdated
Member
There was a problem hiding this comment.
Would just stick with __reduce_ex__ and drop __reduce__. Pickle just needs one of them implemented.
Also as a note __reduce__ doesn’t take any additional arguments.
jakirkham
reviewed
May 10, 2020
Co-authored-by: jakirkham <jakirkham@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cuDF's PR rapidsai/cudf#5132 to optimize
__reduce_ex__in cudf.Buffer broke pickling and serialization in CumlArray, since there only__reduce__was being implemented. This PR addresses that by adding an explicit__reduce_ex__in addition to__reduce__.