Skip to content

wheel builds: react to changes in pip's handling of build constraints#5399

Merged
rapids-bot[bot] merged 7 commits intorapidsai:release/26.02from
mmccarty:fix/new-build-constraint
Jan 20, 2026
Merged

wheel builds: react to changes in pip's handling of build constraints#5399
rapids-bot[bot] merged 7 commits intorapidsai:release/26.02from
mmccarty:fix/new-build-constraint

Conversation

@mmccarty
Copy link
Contributor

@mmccarty mmccarty commented Jan 15, 2026

Description

Contributes to rapidsai/build-planning#242

Modifying ci/build_wheel.sh to

  • pass--build-constraint="${PIP_CONSTRAINT}" unless build isolation is enabled.
  • unset PIP_CONSTRAINT (set by rapids-init-pip)... it doesn't affect builds as of pip 25.3, and results in an error from pip wheel when set and --build-constraint is also passed

@mmccarty mmccarty requested a review from jameslamb January 15, 2026 21:24
@mmccarty mmccarty requested a review from a team as a code owner January 15, 2026 21:24
@mmccarty mmccarty added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 15, 2026
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to also update comments like these, which are no longer accurate:

# Using env variable PIP_CONSTRAINT (initialized by 'rapids-init-pip') is necessary to ensure the constraints
# are used when creating the isolated build environment.

Similar to what you did in the RMM PR: https://github.com/rapidsai/rmm/pull/2212/files#diff-616eb8e64286a9a59a2cd9c77d817fba66ce78ecfdde635db9f4028b74349585R25

Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the builds look good. There's just one more comment that was missed, please update that then feel free to merge this.

@mmccarty mmccarty force-pushed the fix/new-build-constraint branch from 331c23a to d30d595 Compare January 16, 2026 17:42
@mmccarty mmccarty requested a review from a team as a code owner January 16, 2026 17:42
@mmccarty mmccarty changed the base branch from main to release/26.02 January 16, 2026 17:42
@jameslamb
Copy link
Member

/merge

@rapids-bot rapids-bot bot merged commit 797e5b5 into rapidsai:release/26.02 Jan 20, 2026
208 of 215 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants