Skip to content

Revert "Temporarily skip CUDA 11 wheel CI"#4879

Merged
AyodeAwe merged 1 commit intobranch-25.02from
revert-4876-skip-cuda-11-wheel-ci
Jan 22, 2025
Merged

Revert "Temporarily skip CUDA 11 wheel CI"#4879
AyodeAwe merged 1 commit intobranch-25.02from
revert-4876-skip-cuda-11-wheel-ci

Conversation

@bdice
Copy link
Contributor

@bdice bdice commented Jan 22, 2025

Reverts #4876 now that rapidsai/raft#2548 has landed.

@bdice bdice requested a review from a team as a code owner January 22, 2025 11:34
@bdice bdice requested a review from gforsyth January 22, 2025 11:34
@jameslamb jameslamb requested review from jameslamb and removed request for gforsyth January 22, 2025 14:08
@jameslamb jameslamb added improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Jan 22, 2025
Copy link
Member

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is failing check-nightly-ci (https://github.com/rapidsai/cugraph/actions/runs/12907341055/job/35999111103?pr=4879).

I just restarted the 2 failed jobs on the most recent nightly tests as I think both might be fixed by the work from rapidsai/build-planning#137

https://github.com/rapidsai/cugraph/actions/runs/12882240011

@jameslamb
Copy link
Member

The re-runs of nightly tests failed like this:

E ImportError: libcugraph.so: cannot open shared object file: No such file or directory

Suspect that might be a bad mix of packages build at different time while rolling out the fixes from rapidsai/raft#2548. If all other CI passes here on this PR, I think it'd be ok to admin-merge this.

And then I'll trigger a new branch test build after the packages are published, and confirm that passes.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.69%. Comparing base (9026ae5) to head (3a0977c).
Report is 5 commits behind head on branch-25.02.

Additional details and impacted files
@@               Coverage Diff                @@
##           branch-25.02    #4879      +/-   ##
================================================
- Coverage         67.71%   67.69%   -0.02%     
================================================
  Files               150      150              
  Lines             11120    11120              
================================================
- Hits               7530     7528       -2     
- Misses             3590     3592       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vyasr
Copy link
Contributor

vyasr commented Jan 22, 2025

@jameslamb yeah I agree. Let's go ahead and get this merged and try a new build.

@AyodeAwe AyodeAwe merged commit 22aa2e1 into branch-25.02 Jan 22, 2025
80 of 82 checks passed
@vyasr vyasr deleted the revert-4876-skip-cuda-11-wheel-ci branch January 22, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improvement / enhancement to an existing function non-breaking Non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants