Remove GNN Packages by alexbarghi-nv · Pull Request #4765 · rapidsai/cugraph

alexbarghi-nv · 2024-11-14T23:32:51Z

Removes the GNN packages, which are now part of cugraph-gnn.

review-notebook-app · 2024-11-14T23:32:57Z

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

jameslamb

I pulled this branch and searched like this:

git grep -E -i 'dgl|pyg'

Found some more things that I think should be deleted.

test files:

test code:

cugraph/ci/test.sh

Lines 102 to 107 in c712a98

    
           echo "Python pytest for cugraph_pyg (single-GPU only)..." 
        
           conda list 
        
           cd ${CUGRAPH_ROOT}/python/cugraph-pyg/cugraph_pyg 
        
           # rmat is not tested because of MG testing 
        
           pytest -sv -m sg --cache-clear --junitxml=${CUGRAPH_ROOT}/junit-cugraph-pytests.xml -v --cov-config=.coveragerc --cov=cugraph_pyg --cov-report=xml:${WORKSPACE}/python/cugraph_pyg/cugraph-coverage.xml --cov-report term --ignore=raft --benchmark-disable 
        
           echo "Ran Python pytest for cugraph_pyg : return code was: $?, test script exit code is now: $EXITCODE"

the conda recipes:

Test coverage config:

cugraph/python/.coveragerc

Line 4 in c712a98

cugraph-pyg/cugraph_pyg/*

cugraph/python/.coveragerc

Line 8 in c712a98

cugraph-pyg/cugraph_pyg/tests/*

…v/cugraph into remove-gnn-packages

alexbarghi-nv · 2024-11-15T00:03:30Z

I pulled this branch and searched like this:
git grep -E -i 'dgl|pyg'
Found some more things that I think should be deleted.

test files:

https://github.com/rapidsai/cugraph/blob/branch-24.12/ci/run_cugraph_pyg_pytests.sh

https://github.com/rapidsai/cugraph/blob/branch-24.12/ci/run_cugraph_dgl_pytests.sh

test code:

cugraph/ci/test.sh

Lines 102 to 107 in c712a98

echo "Python pytest for cugraph_pyg (single-GPU only)..."

conda list

cd ${CUGRAPH_ROOT}/python/cugraph-pyg/cugraph_pyg

# rmat is not tested because of MG testing

pytest -sv -m sg --cache-clear --junitxml=${CUGRAPH_ROOT}/junit-cugraph-pytests.xml -v --cov-config=.coveragerc --cov=cugraph_pyg --cov-report=xml:${WORKSPACE}/python/cugraph_pyg/cugraph-coverage.xml --cov-report term --ignore=raft --benchmark-disable

echo "Ran Python pytest for cugraph_pyg : return code was: $?, test script exit code is now: $EXITCODE"

the conda recipes:

https://github.com/rapidsai/cugraph/tree/branch-24.12/conda/recipes/cugraph-dgl

https://github.com/rapidsai/cugraph/tree/branch-24.12/conda/recipes/cugraph-pyg

Test coverage config:

cugraph/python/.coveragerc

Line 4 in c712a98

cugraph-pyg/cugraph_pyg/*

cugraph/python/.coveragerc

Line 8 in c712a98

cugraph-pyg/cugraph_pyg/tests/*

These should be taken care of now.

alexbarghi-nv · 2024-11-15T00:03:46Z

The benchmarks are going to stay for now; those will go away in 25.02.

jameslamb · 2024-11-15T17:13:32Z

CI here is going to fail until some other things are resolved.

cugraph-dgl / cugraph-pyg need to be removed from devcontainers manifest: move cugraph projects around for 24.12 devcontainers#417
new pylibwholegraph nightlies need to be published: remove versioning workaround for nightlies cugraph-gnn#69

…v/cugraph into remove-gnn-packages

…packages

bdice · 2024-11-22T03:51:49Z

I merged in the upstream and resolved conflicts with #4762. Based on the mostly-complete CI run from 0694814, I think we might be close to having passing CI now that RAFT kernel symbol failures are resolved. We will know in the morning. 👍

…packages

bdice · 2024-11-22T17:02:51Z

/merge

rlratzel

I think this looks right but I admit I'm relying more on the passing CI status and working nightly packages to say for sure.

@acostadon

This repo should no longer need any build-time dependencies on cloning the `cugraph-ops` source code or pulling in its packages, as of these PRs: * #4744 * #4765 This PR proposes the following: * removing CI configuration related to cloning the `cugraph-ops` repo * removing CMake options related to `cugraph-ops` - `ALLOW_CLONE_CUGRAPH_OPS` - `CUGRAPH_EXCLUDE_CUGRAPH_OPS_FROM_ALL` - `CUGRAPH_USE_CUGRAPH_OPS_STATIC` - `USE_CUGRAPH_OPS` * removing dependencies on `pylibcugraphops` / `libcugraphops` in development scripts, conda recipes * removing the `cugraph-ops` docs, and references to them in other docs * removing unused source file `cpp/src/utilities/cugraph_ops_utils.hpp` * removing the `cugraph_ops` pytest marker ## Notes for Reviewers ### Benefits of these changes * faster CI * simplifies the pending work to introduce `libcugraph` wheel packages (rapidsai/rapids-wheels-planning#53) ### How I identified these changes ```shell git grep -i '_ops' git grep -i '\-ops' git grep -i 'cugraphops' ``` ### Why is this so big? I'd originally wanted to leave the docs-building stuff in place, but saw `docs-build` CI here failing because docs haven't been built from the `cugraph-ops` repo yet: https://github.com/rapidsai/cugraph/blob/c5d3d231c9cac361bf51246c13440a42eeda93b9/build.sh#L334-L341 Talked offline with @acostadon and @ChuckHastings , and we agreed that those docs could just be removed here. ### What is intentionally being left? * references in licenses (as some code from `cugraph-ops` is vendored here) * references in the docs for the GNN packages (`cugraph-dgl`, `cugraph-pyg`, `pylibwholegraph`), as those do still rely on `cugraph-ops` (their docs will eventually move out of this repo) Authors: - James Lamb (https://github.com/jameslamb) Approvers: - Kyle Edwards (https://github.com/KyleFromNVIDIA) - Alex Barghi (https://github.com/alexbarghi-nv) - Chuck Hastings (https://github.com/ChuckHastings) URL: #4784

remove files, update

6aea41b

alexbarghi-nv requested review from a team as code owners November 14, 2024 23:32

alexbarghi-nv requested a review from jameslamb November 14, 2024 23:32

github-actions bot added python conda labels Nov 14, 2024

Delete cpp/src/c_api/.nfs0000000001225db000000a4f

fb4bf01

jameslamb reviewed Nov 14, 2024

View reviewed changes

alexbarghi-nv added 2 commits November 14, 2024 16:00

remove additional files and references

32e0cc4

Merge branch 'remove-gnn-packages' of https://github.com/alexbarghi-n…

999d618

…v/cugraph into remove-gnn-packages

alexbarghi-nv requested a review from a team as a code owner November 15, 2024 00:01

alexbarghi-nv requested a review from msarahan November 15, 2024 00:01

github-actions bot added the ci label Nov 15, 2024

alexbarghi-nv self-assigned this Nov 15, 2024

alexbarghi-nv added improvement Improvement / enhancement to an existing function breaking Breaking change labels Nov 15, 2024

Merge branch 'branch-24.12' into remove-gnn-packages

04b1697

alexbarghi-nv added 2 commits November 19, 2024 09:22

merge

cd4668a

Merge branch 'remove-gnn-packages' of https://github.com/alexbarghi-n…

0694814

…v/cugraph into remove-gnn-packages

KyleFromNVIDIA approved these changes Nov 19, 2024

View reviewed changes

Merge branch 'branch-24.12' into remove-gnn-packages

5e5809e

ChuckHastings approved these changes Nov 21, 2024

View reviewed changes

Merge remote-tracking branch 'upstream/branch-24.12' into remove-gnn-…

0589af2

…packages

bdice added 2 commits November 21, 2024 21:53

Remove cugraph_pyg customizations for devcontainers.

9cc8e72

Fix references to some removed content.

015f394

bdice approved these changes Nov 22, 2024

View reviewed changes

Merge remote-tracking branch 'upstream/branch-24.12' into remove-gnn-…

2aa9151

…packages

rlratzel approved these changes Nov 22, 2024

View reviewed changes

rapids-bot bot merged commit 5e19f4a into rapidsai:branch-24.12 Nov 22, 2024

alexbarghi-nv deleted the remove-gnn-packages branch November 22, 2024 17:10

jameslamb mentioned this pull request Nov 25, 2024

remove all remaining uses of cugraph-ops #4784

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove GNN Packages#4765

Remove GNN Packages#4765
rapids-bot[bot] merged 12 commits intorapidsai:branch-24.12from
alexbarghi-nv:remove-gnn-packages

alexbarghi-nv commented Nov 14, 2024

Uh oh!

review-notebook-app bot commented Nov 14, 2024

Uh oh!

jameslamb left a comment

Uh oh!

alexbarghi-nv commented Nov 15, 2024

Uh oh!

alexbarghi-nv commented Nov 15, 2024

Uh oh!

jameslamb commented Nov 15, 2024

Uh oh!

bdice commented Nov 22, 2024

Uh oh!

bdice commented Nov 22, 2024

Uh oh!

rlratzel left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

	echo "Python pytest for cugraph_pyg (single-GPU only)..."
	conda list
	cd ${CUGRAPH_ROOT}/python/cugraph-pyg/cugraph_pyg
	# rmat is not tested because of MG testing
	pytest -sv -m sg --cache-clear --junitxml=${CUGRAPH_ROOT}/junit-cugraph-pytests.xml -v --cov-config=.coveragerc --cov=cugraph_pyg --cov-report=xml:${WORKSPACE}/python/cugraph_pyg/cugraph-coverage.xml --cov-report term --ignore=raft --benchmark-disable
	echo "Ran Python pytest for cugraph_pyg : return code was: $?, test script exit code is now: $EXITCODE"

Conversation

alexbarghi-nv commented Nov 14, 2024

Uh oh!

review-notebook-app bot commented Nov 14, 2024

Uh oh!

jameslamb left a comment

Choose a reason for hiding this comment

Uh oh!

alexbarghi-nv commented Nov 15, 2024

Uh oh!

alexbarghi-nv commented Nov 15, 2024

Uh oh!

jameslamb commented Nov 15, 2024

Uh oh!

bdice commented Nov 22, 2024

Uh oh!

bdice commented Nov 22, 2024

Uh oh!

rlratzel left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants