Remove nx-cugraph from this repo#4756
Conversation
This is part of the migration to https://github.com/rapidsai/nx-cugraph This is meant to fully remove nx-cugraph *except* for docs, which are still built from this repo.
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Note that I changed some links in the README and a couple of the docs. |
jameslamb
left a comment
There was a problem hiding this comment.
Thanks! I searched this branch like this:
git grep -i nxFound just one other thing that probably could now be removed:
Lines 26 to 28 in a5fdc8b
Do whatever you want with that.
Marking this "Approve" because otherwise everything here looks great to me!
Ha, I left a similar comment here: #4748 (review) I think we can try removing it once we get CI to pass, which I think will need rapidsai/devcontainers#417 or rapidsai/devcontainers#418 |
use `#supported-algorithms`, not `#algorithms`
I believe this is needed to remove `nx-cugraph` from the `cugraph` repo being done in rapidsai/cugraph#4756 This is a subset of the changes @jameslamb is making in #417. Does it make sense to do this change for `nx-cugraph` and `cugraph-gnn` independently (how close is `cugraph-gnn` to being removed?)? Should we also add `nx-cugraph` as done in that PR? Anything else? @nv-rliu @jameslamb @rlratzel
|
This PR is passing CI and has been approved. Who would like to do the honors of merging? |
|
/merge |
This is part of the migration to https://github.com/rapidsai/nx-cugraph
This is meant to fully remove nx-cugraph except for docs, which are still built from this repo.
CC @nv-rliu @jameslamb @rlratzel