nx-cugraph: fix from_pandas_edgekey given edgekey but not edgeattr#4550
Merged
rapids-bot[bot] merged 3 commits intorapidsai:branch-24.08from Jul 30, 2024
Merged
Conversation
rlratzel
approved these changes
Jul 24, 2024
Contributor
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes this: networkx/networkx#7466
We would catch this (and other changes) if we tested networkx nightlies. Someday!
I kept the buggy behavior for older versions of networkx in order to match networkx, which feels kinda silly, but also okay-ish.