Skip to content

remove thriftpy2 ceiling#4521

Merged
rapids-bot[bot] merged 5 commits intorapidsai:branch-24.08from
jameslamb:update-thriftpy2
Jul 19, 2024
Merged

remove thriftpy2 ceiling#4521
rapids-bot[bot] merged 5 commits intorapidsai:branch-24.08from
jameslamb:update-thriftpy2

Conversation

@jameslamb
Copy link
Member

#4496 introduced a ceiling on thriftpy2. Context: #4496 (comment)

The bug that ceiling was added to avoid was fixed in v0.5.2 of thriftpy2, which was just released (#4478 (comment)).

This removes that, adding != constraints to skip the 2 versions that cugraph was not compatible with.

Notes for Reviewers

Why not a floor?

I'm proposing adding != constraints to skip v0.5.0 and v0.5.1 to maximize cugraph's compatibility with other environments... that'd allow it to be used in environments with thriftpy2<0.5.0 and in environments with thriftpy2>0.5.2.

Let me know if you'd prefer the simplicity of a floor like >=0.5.2 instead.

@jameslamb
Copy link
Member Author

jameslamb commented Jul 5, 2024

This is blocked until #4522 is merged.

@jameslamb jameslamb changed the title WIP: remove thriftpy2 ceiling remove thriftpy2 ceiling Jul 8, 2024
@jameslamb jameslamb marked this pull request as ready for review July 8, 2024 19:17
@jameslamb jameslamb requested a review from a team as a code owner July 8, 2024 19:17
@jameslamb jameslamb requested review from bdice, nv-rliu and rlratzel July 8, 2024 19:17
@jameslamb
Copy link
Member Author

/merge

@rapids-bot rapids-bot bot merged commit c9d2843 into rapidsai:branch-24.08 Jul 19, 2024
@jameslamb jameslamb deleted the update-thriftpy2 branch July 22, 2024 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conda improvement Improvement / enhancement to an existing function non-breaking Non-breaking change python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants