[REVIEW] ENH Update Force Atlas 2 notebook, wrapper and coding style - #1273
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Please update the changelog in order to start CI tests. View the gpuCI docs here. |
Codecov Report
@@ Coverage Diff @@
## branch-0.17 #1273 +/- ##
===============================================
+ Coverage 56.59% 57.80% +1.20%
===============================================
Files 62 63 +1
Lines 2564 2782 +218
===============================================
+ Hits 1451 1608 +157
- Misses 1113 1174 +61
Continue to review full report at Codecov.
|
afender
left a comment
There was a problem hiding this comment.
Consider removing your local output for the first notebook cell :
Requirement already satisfied: fa2 in /home/hlinsenmaier/anaconda3/envs/cugraph_dev2/lib/python3.8/site-packages (0.3.5)
Requirement already satisfied: scipy in /home/hlinsenmaier/anaconda3/envs/cugraph_dev2/lib/python3.8/site-packages (from fa2) (1.5.3)
Requirement already satisfied: numpy in /home/hlinsenmaier/anaconda3/envs/cugraph_dev2/lib/python3.8/site-packages (from fa2) (1.19.4)
Requirement already satisfied: tqdm in /home/hlinsenmaier/anaconda3/envs/cugraph_dev2/lib/python3.8/site-packages (from fa2) (4.52.0)
554fb9d to
cc7124c
Compare
Fixed in commit cc7124c |
ajschmidt8
left a comment
There was a problem hiding this comment.
Looks good. We'll need the new Notebook dependencies added to our rapids-notebook-env metapackage below. Please open a PR for that before this can be merged. Also, if these new dependencies change frequently, please consider pinning them as well (though I'll leave that to your discretion since I don't know much about them).
ajschmidt8
left a comment
There was a problem hiding this comment.
PR rapidsai/integration#174 is merged, so this is good to go. thanks Hugo
This PR updates the notebook for the blog post, the Python bindings and addresses the FIXMEs related to stream usage.