Skip to content

Update Matrix Filters to Enable Python 3.14 Tests and Disable 12.2 Tests - #454

Merged
jameslamb merged 2 commits into
rapidsai:mainfrom
alexbarghi-nv:disable-12.2
May 4, 2026
Merged

jameslamb merged 2 commits into
rapidsai:mainfrom
alexbarghi-nv:disable-12.2

Conversation

@alexbarghi-nv

Copy link
Copy Markdown
Member

Update the matrix filters to test on Python 3.14 and temporarily disable 12.2 tests, and any other potential tests on CUDA < 12.9, until the issues with cuGraph are resolved.

@alexbarghi-nv
alexbarghi-nv requested a review from a team as a code owner May 4, 2026 17:14
@alexbarghi-nv
alexbarghi-nv requested a review from gforsyth May 4, 2026 17:14
@alexbarghi-nv alexbarghi-nv self-assigned this May 4, 2026
@alexbarghi-nv alexbarghi-nv added breaking Introduces a breaking change bug Something isn't working labels May 4, 2026
@greptile-apps

greptile-apps Bot commented May 4, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Removes the Python 3.14 exclusion and replaces the old per-architecture CUDA 12.2 filter with a unified CUDA_VER >= "12.9.0" guard across all six test jobs in both workflow files. The or is correctly placed inside select, so the logic is sound — two minor points worth noting are the redundant arch conditions (which simplify to a plain CUDA version check) and a potential future problem if CUDA 12.10.x entries ever appear in the matrix, since jq string comparison would misorder them.

Confidence Score: 5/5

Safe to merge; all findings are P2 and the filter logic is correct for current CUDA versions.

No P0 or P1 issues. The jq logic is correct. Concerns are forward-looking (potential CUDA 12.10.x) and stylistic (redundant arch clause).

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/pr.yaml Removes Python 3.14 exclusion and tightens CUDA filter to >= 12.9.0 across three test jobs; or is now correctly inside select, but string comparison could mishandle 12.10.x versions.
.github/workflows/test.yaml Mirrors the same filter changes from pr.yaml; same lexicographic comparison caveat applies.

Reviews (2): Last reviewed commit: "update matrix filter to select whole" | Re-trigger Greptile

Comment thread .github/workflows/pr.yaml Outdated
Comment thread .github/workflows/pr.yaml
@jameslamb
jameslamb removed the request for review from gforsyth May 4, 2026 18:52
@jameslamb

Copy link
Copy Markdown
Member

The devcontainer failure is unrelated and probably the result of this incident: https://status.canonical.com/#/incident/KNms6QK9ewuzz-7xUsPsNylV20jEt5kyKsd8A-3ptQG1OfBTMZO_fBkVMmGqQC3NLBLamiI6KOEL7KpsobFJ4Q==

  534.4 Ign:1 http://archive.ubuntu.com/ubuntu noble/universe amd64 pigz amd64 2.8-1
  595.9 Ign:2 http://archive.ubuntu.com/ubuntu noble/main amd64 bc amd64 1.07.1-3ubuntu4
  658.4 Err:1 http://archive.ubuntu.com/ubuntu noble/universe amd64 pigz amd64 2.8-1
  658.4   Connection failed [IP: 91.189.92.23 80]
  720.8 Err:2 http://archive.ubuntu.com/ubuntu noble/main amd64 bc amd64 1.07.1-3ubuntu4
  720.8   Connection failed [IP: 91.189.91.83 80]
  720.8 E: Failed to fetch http://archive.ubuntu.com/ubuntu/pool/universe/p/pigz/pigz_2.8-1_amd64.deb  Connection failed [IP: 91.189.92.23 80]
  720.8 E: Failed to fetch http://archive.ubuntu.com/ubuntu/pool/main/b/bc/bc_1.07.1-3ubuntu4_amd64.deb  Connection failed [IP: 91.189.91.83 80]
  720.8 E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
  720.8 ERROR: Feature "NVIDIA RAPIDS devcontainer build utilities" (ghcr.io/rapidsai/devcontainers/features/rapids-build-utils) failed to install!

(build link)

And check-nightly-ci should be fixed by this.

I'll admin-merge this.

@jameslamb

Copy link
Copy Markdown
Member

until the issues with cuGraph are resolved

Noting for those finding this from search that that's this: rapidsai/cugraph#5498

@jameslamb
jameslamb merged commit 0d87066 into rapidsai:main May 4, 2026
83 of 86 checks passed
rapids-bot Bot pushed a commit that referenced this pull request May 14, 2026
## Summary
- restore CUDA 12.2 test matrix coverage removed in #454
- restore Python 3.14 CI coverage removed in #433
- keep the existing arm64 CUDA 12.2 exclusion
- follows the CUDA 12.2 runtime fix from rapidsai/cugraph#5499

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Alex Barghi (https://github.com/alexbarghi-nv)
  - https://github.com/jakirkham

URL: #457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Introduces a breaking change bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants