Skip to content

check-nightly-ci: reset to 7 days#442

Merged
rapids-bot[bot] merged 1 commit intorapidsai:release/26.04from
jameslamb:fix-nightly-threshold
Mar 25, 2026
Merged

check-nightly-ci: reset to 7 days#442
rapids-bot[bot] merged 1 commit intorapidsai:release/26.04from
jameslamb:fix-nightly-threshold

Conversation

@jameslamb
Copy link
Copy Markdown
Member

@jameslamb jameslamb commented Mar 25, 2026

Fixes #410

#434 was the last step to unblocking nightly CI in this project. This reverts #419. Once this is merged, PR CI will be blocked if the project goes 7 days without passing nightly tests.

How I tested this:

  1. manually triggered a build run on release/26.04 (link)
  2. manually triggered a test run on release/26.04 (link)
  3. re-ran the check-nightly-ci check here and saw it pass (link)
Found 1 successful runs of workflow 'test.yaml' on branch 'release/26.04' in the previous 7 days (most recent: '2026-03-25 19:59:38+00:00'). View logs:
 - https://github.com/rapidsai/cugraph-gnn/actions/runs/23560028629

@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Mar 25, 2026
@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Mar 25, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@jameslamb
Copy link
Copy Markdown
Member Author

/ok to test

@jameslamb jameslamb requested a review from AyodeAwe March 25, 2026 20:39
@jameslamb jameslamb changed the title WIP: check-nightly-ci: reset to 7 days check-nightly-ci: reset to 7 days Mar 25, 2026
target-branch: ${{ fromJSON(steps.get-pr-info.outputs.pr-info).base.ref }}
# TODO: remove 'max-days-without-success' once https://github.com/rapidsai/cugraph-gnn/issues/410 is fixed
max-days-without-success: 50
max-days-without-success: 7
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the default, but just keeping it here to be explicit.

@jameslamb jameslamb marked this pull request as ready for review March 25, 2026 20:40
@jameslamb jameslamb requested a review from a team as a code owner March 25, 2026 20:40
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Mar 25, 2026

Greptile Summary

Reverts the temporary max-days-without-success: 50 override (introduced in #419) back to the standard 7 days, now that nightly CI is unblocked. Also removes the associated TODO comment tied to issue #410.

Confidence Score: 5/5

  • Safe to merge — simple revert of a known temporary workaround, verified by manual CI runs.
  • Single-line config change with clear intent, corresponding issue fixed, and the author verified it passes CI manually.
  • No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/pr.yaml Resets max-days-without-success from the temporary 50-day override back to 7 days, and removes the associated TODO comment. Straightforward revert of a previous workaround.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR Opened] --> B[check-nightly-ci job]
    B --> C{Last successful nightly run\nwithin 7 days?}
    C -- Yes --> D[CI passes ✅]
    C -- No --> E[CI blocked ❌]
Loading

Reviews (1): Last reviewed commit: "check-nightly-ci: reset to 7 days" | Re-trigger Greptile

@jameslamb
Copy link
Copy Markdown
Member Author

/merge

@rapids-bot rapids-bot bot merged commit 1ec31a0 into rapidsai:release/26.04 Mar 25, 2026
120 of 122 checks passed
@jameslamb jameslamb deleted the fix-nightly-threshold branch March 25, 2026 20:47
@jameslamb
Copy link
Copy Markdown
Member Author

yesterday's release/26.04 nightly tests passed 😎

https://github.com/rapidsai/cugraph-gnn/actions/runs/23704040719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants