Skip to content

enable arm64 wheel tests, remove pytest.ini, add a coverage floor #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rapids-bot merged 9 commits into from
Apr 9, 2026
Merged

enable arm64 wheel tests, remove pytest.ini, add a coverage floor #438

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8c3ee14
enable arm64 wheel tests, remove pytest.ini, add a coverage floor
jameslamb Mar 31, 2026
7fbdfad
whitespace
jameslamb Mar 31, 2026
5632e6d
fix indentation and quoting in pyproject.toml
jameslamb Mar 31, 2026
8f80c39
update arm64 + 'oldest' torch requirement
jameslamb Apr 1, 2026
f2d52bc
Merge branch 'main' into misc/testing-improvements
jameslamb Apr 1, 2026
750c764
resolve duplicates
jameslamb Apr 1, 2026
0144cd4
Merge branch 'misc/testing-improvements' of github.com:jameslamb/cugr…
jameslamb Apr 1, 2026
231da45
revert nightly-testing stuff
jameslamb Apr 1, 2026
4fbd65f
Merge branch 'main' into misc/testing-improvements
jameslamb Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 24 additions & 2 deletions .github/workflows/pr.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,10 @@ jobs:
- wheel-build-libwholegraph
- wheel-build-pylibwholegraph
- wheel-tests-pylibwholegraph
- wheel-tests-nightly-pylibwholegraph
Comment thread
jameslamb marked this conversation as resolved.
Outdated
- wheel-build-cugraph-pyg
- wheel-tests-cugraph-pyg
- wheel-tests-nightly-cugraph-pyg
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/pr-builder.yaml@main
if: always()
Expand Down Expand Up @@ -257,7 +259,17 @@ jobs:
with:
build_type: pull-request
script: ci/test_wheel_pylibwholegraph.sh
matrix_filter: map(select(.PY_VER != "3.14")) | map(select(.ARCH == "amd64"))
matrix_filter: map(select(.PY_VER != "3.14"))
wheel-tests-nightly-pylibwholegraph:
needs: [wheel-build-pylibwholegraph, changed-files]
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@release/26.04
if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python_wheels
with:
build_type: pull-request
script: ci/test_wheel_pylibwholegraph.sh
matrix_filter: map(select(.PY_VER != "3.14"))
matrix_type: nightly
wheel-build-cugraph-pyg:
needs: checks
secrets: inherit
Expand All @@ -279,4 +291,14 @@ jobs:
with:
build_type: pull-request
script: ci/test_wheel_cugraph-pyg.sh
matrix_filter: map(select(.PY_VER != "3.14")) | map(select(.ARCH == "amd64"))
matrix_filter: map(select(.PY_VER != "3.14"))
wheel-tests-nightly-cugraph-pyg:
needs: [wheel-build-pylibwholegraph, wheel-build-cugraph-pyg, changed-files]
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@release/26.04
if: fromJSON(needs.changed-files.outputs.changed_file_groups).test_python_wheels
with:
build_type: pull-request
script: ci/test_wheel_cugraph-pyg.sh
matrix_filter: map(select(.PY_VER != "3.14"))
matrix_type: nightly
4 changes: 2 additions & 2 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
date: ${{ inputs.date }}
sha: ${{ inputs.sha }}
script: ci/test_wheel_pylibwholegraph.sh
matrix_filter: map(select(.PY_VER != "3.14")) | map(select(.ARCH == "amd64"))
matrix_filter: map(select(.PY_VER != "3.14"))
wheel-tests-cugraph-pyg:
secrets: inherit
uses: rapidsai/shared-workflows/.github/workflows/wheels-test.yaml@main
Expand All @@ -63,4 +63,4 @@ jobs:
date: ${{ inputs.date }}
sha: ${{ inputs.sha }}
script: ci/test_wheel_cugraph-pyg.sh
matrix_filter: map(select(.PY_VER != "3.14")) | map(select(.ARCH == "amd64"))
matrix_filter: map(select(.PY_VER != "3.14"))
17 changes: 12 additions & 5 deletions ci/test_wheel_cugraph-pyg.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,22 +64,29 @@ rapids-pip-retry install \

# RAPIDS_DATASET_ROOT_DIR is used by test scripts
export RAPIDS_DATASET_ROOT_DIR="$(realpath datasets)"
mkdir -p "${RAPIDS_DATASET_ROOT_DIR}"
pushd "${RAPIDS_DATASET_ROOT_DIR}"
./get_test_data.sh --test
popd

# Enable legacy behavior of torch.load for examples relying on ogb
export TORCH_FORCE_NO_WEIGHTS_ONLY_LOAD=1

if [[ "${torch_downloaded}" == "true" ]]; then

# only need to download datasets if 'torch' is installed, otherwise all the
# tests using them are skipped
mkdir -p "${RAPIDS_DATASET_ROOT_DIR}"
pushd "${RAPIDS_DATASET_ROOT_DIR}"
./get_test_data.sh --test
popd

# 'torch' is an optional dependency of 'cugraph-pyg'... confirm that it's actually
# installed here and that we've installed a package with CUDA support.
rapids-logger "Confirming that PyTorch is installed"
python -c "import torch; assert torch.cuda.is_available()"

rapids-logger "pytest cugraph-pyg (single GPU, with 'torch' and 'torch-geometric')"
./ci/run_cugraph_pyg_pytests.sh
./ci/run_cugraph_pyg_pytests.sh \
--cov-config=../../.coveragerc \
--cov=cugraph_pyg \
--cov-fail-under=70
fi

rapids-logger "import cugraph-pyg (no 'torch' or 'torch-geometric')"
Expand Down
5 changes: 4 additions & 1 deletion ci/test_wheel_pylibwholegraph.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,10 @@ if [[ "${torch_downloaded}" == "true" ]]; then
python -c "import torch; assert torch.cuda.is_available()"

rapids-logger "pytest pylibwholegraph (with 'torch')"
./ci/run_pylibwholegraph_pytests.sh
./ci/run_pylibwholegraph_pytests.sh \
--cov-config=../../.coveragerc \
--cov=pylibwholegraph \
--cov-fail-under=15

@jameslamb jameslamb Mar 31, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm proposing this because of all the test-skipping stuff added in #425 and #434 ... all that test-skipping logic makes me nervous.

Hoping that having a coverage minimum enforced right here, in a place where we expect torch to be installed, will help prevent bugs of the form "oops all the tests are being skipped" when the fixtures, import_optional(), etc. are refactored in the future.

fi

rapids-logger "import pylibwholegraph (no 'torch')"
Expand Down
12 changes: 12 additions & 0 deletions python/cugraph-pyg/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,18 @@ requires = [
build-backend = "rapids_build_backend.build"

[tool.pytest.ini_options]
addopts = [
"--benchmark-warmup=off",
"--benchmark-max-time=0",
"--benchmark-min-rounds=1",
"--benchmark-columns=mean, rounds",
"-m \"not slow\"",
]
markers = [
"slow: slow-running tests/benchmarks",
"mg: Test MG code paths - number of gpu > 1",
"sg: Test SG code paths - number of gpu == 1",
]
testpaths = ["cugraph_pyg/tests"]
Comment thread
jameslamb marked this conversation as resolved.

[project]
Expand Down
28 changes: 0 additions & 28 deletions python/cugraph-pyg/pytest.ini
View file
Open in desktop

This file was deleted.

Loading